After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694064 - Fix two bugs in controls animations
Fix two bugs in controls animations
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-18 06:27 UTC by Cosimo Cecchi
Modified: 2013-02-18 14:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
overviewControls: fix math for translations when sliding in (1.82 KB, patch)
2013-02-18 06:27 UTC, Cosimo Cecchi 		none Details | Review
overviewControls: update slide in translations from pageEmpty (1.22 KB, patch)
2013-02-18 06:27 UTC, Cosimo Cecchi 		committed Details | Review
overviewControls: fix math for translations when sliding in (1.49 KB, patch)
2013-02-18 06:43 UTC, Cosimo Cecchi 		none Details | Review
overviewControls: fix math for translations when sliding in (1.25 KB, patch)
2013-02-18 06:58 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2013-02-18 06:27:41 UTC 
See attached patches
Comment 1 Cosimo Cecchi 2013-02-18 06:27:44 UTC 
Created attachment 236553 [details] [review]
overviewControls: fix math for translations when sliding in

The math to compute translations was wrong when sliding in.
Comment 2 Cosimo Cecchi 2013-02-18 06:27:52 UTC 
Created attachment 236554 [details] [review]
overviewControls: update slide in translations from pageEmpty

Now that we unified animation times, move in controls together with the
new view.
Comment 3 Cosimo Cecchi 2013-02-18 06:43:00 UTC 
Created attachment 236555 [details] [review]
overviewControls: fix math for translations when sliding in

--

Much simpler version.
Comment 4 Cosimo Cecchi 2013-02-18 06:58:49 UTC 
Created attachment 236557 [details] [review]
overviewControls: fix math for translations when sliding in

--

Argh, fix rebase error
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-02-18 09:15:22 UTC 
Review of attachment 236557 [details] [review]:

OK.
Comment 6 Jasper St. Pierre (not reading bugmail) 2013-02-18 09:16:14 UTC 
Review of attachment 236554 [details] [review]:

::: js/ui/overviewControls.js
@@ +198,3 @@
         this.layout.slideX = this.getSlide();
+        if (this.visible)
+            this._updateTranslation(true);

Perhaps updateTranslation should DTRT wrt. being visible vs. invisible?
Comment 7 Cosimo Cecchi 2013-02-18 14:33:38 UTC 
(In reply to comment #6)

> Perhaps updateTranslation should DTRT wrt. being visible vs. invisible?

I think this is a good idea.
Comment 8 Cosimo Cecchi 2013-02-18 14:34:42 UTC 
Attachment 236554 [details] pushed as ccb8191 - overviewControls: update slide in translations from pageEmpty
Attachment 236557 [details] pushed as 4505c38 - overviewControls: fix math for translations when sliding in

Pushed with the suggested fix.