After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694035 - overviewControls: Reduce the time it takes to slide in/out
overviewControls: Reduce the time it takes to slide in/out
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-17 18:31 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-02-18 05:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
overviewControls: Reduce the time it takes to slide in/out (2.06 KB, patch)
2013-02-17 18:31 UTC, Jasper St. Pierre (not reading bugmail)
none Details | Review
overviewControls: synchronize viewSelector fade and controls slide (2.07 KB, patch)
2013-02-18 05:27 UTC, Cosimo Cecchi
committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-02-17 18:31:16 UTC
This is a follow-up to the new search controls stuff, just so
we don't forget it. The discrepancy is much more noticeable when
using St.set_slow_down_factor(5) or so.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-02-17 18:31:18 UTC
Created attachment 236474 [details] [review]
overviewControls: Reduce the time it takes to slide in/out

As the slide animation is now aligned with one fade in or out
of a page, we should make it take the same amount of time as
fading in or out of a page.
Comment 2 Cosimo Cecchi 2013-02-17 18:38:09 UTC
I think this is a good idea, but I'd like to get a confirmation from a designer first.
Comment 3 Allan Day 2013-02-18 00:55:35 UTC
I've tried the patch, and it actually seems a bit fast to me.
Comment 4 Cosimo Cecchi 2013-02-18 05:27:53 UTC
Created attachment 236548 [details] [review]
overviewControls: synchronize viewSelector fade and controls slide

If the animation time is not the same for these two, the translation
will be adjusted to the allocation during the tween, resulting in a jump
in the animation.

--

It's worth noting that using the same time for these animations allows us to fix a glitch in the current slide animation.
I experimented with various time values and I find this is a good speed for me.
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-02-18 05:28:51 UTC
Review of attachment 236548 [details] [review]:

OK.
Comment 6 Cosimo Cecchi 2013-02-18 05:34:08 UTC
Attachment 236548 [details] pushed as 73d9ac6 - overviewControls: synchronize viewSelector fade and controls slide