After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694019 - ContainerUpdateIDs signal broken
ContainerUpdateIDs signal broken
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: librygel-server
git master
Other Linux
: High normal
: ---
Assigned To: Krzesimir Nowak
rygel-maint
ivi
Depends on:
Blocks:
 
 
Reported: 2013-02-17 12:28 UTC by Jens Georg
Modified: 2013-02-27 08:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
cleans up and fixes container update signal handling in content directory. (6.96 KB, patch)
2013-02-26 12:03 UTC, Krzesimir Nowak 		none Details | Review
cleans up and fixes container update signal handling in content directory. v2 (6.90 KB, patch)
2013-02-26 12:10 UTC, Krzesimir Nowak 		committed Details | Review
Fix ContainerUpdateIDs variable to hold unique ids. (1.59 KB, patch)
2013-02-26 13:13 UTC, Krzesimir Nowak 		committed Details | Review

Description Jens Georg 2013-02-17 12:28:23 UTC 
For some reason we now signalize <container-id>,0 for every change which isn't right. Might be the logic to set the container-update-id is wrong in http://git.gnome.org/browse/rygel/tree/src/librygel-server/rygel-content-directory.vala#n448 or we should only add them if containerUpdateId really changes.
Comment 1 Mark Ryan 2013-02-20 09:33:53 UTC 
I can confirm this.  If I delete a picture from my ~/Pictures folder ( I'm using media export ) I get 6 Container Updates, including updates for my Music and my Root folder.  All but one of the update signals specifies a ContainerUpdateID of 0.
Comment 2 Michael Hasselmann 2013-02-22 09:30:52 UTC 
Is there any case where ContainerUpdateID == 0 makes a valid use-case?
Comment 3 Mark Ryan 2013-02-22 09:55:08 UTC 
I don't think so.  Containers can have a ContainerUpdateID property of 0 but I think evented values of this property will always be greater than 0.
Comment 4 Krzesimir Nowak 2013-02-26 12:03:13 UTC 
Created attachment 237428 [details] [review]
cleans up and fixes container update signal handling in content directory.
Comment 5 Krzesimir Nowak 2013-02-26 12:10:36 UTC 
Created attachment 237431 [details] [review]
cleans up and fixes container update signal handling in content directory. v2

I suppose that some code in MediaExport plugin needs to be fixed as well to avoid receiving updates from some music related container when picture is deleted.
Comment 6 Krzesimir Nowak 2013-02-26 13:13:33 UTC 
Created attachment 237435 [details] [review]
Fix ContainerUpdateIDs variable to hold unique ids.
Comment 7 Jens Georg 2013-02-26 13:54:45 UTC 
Review of attachment 237435 [details] [review]:

Good catch, that was broken for a long time apparently.
Comment 8 Jens Georg 2013-02-26 14:55:42 UTC 
Review of attachment 237431 [details] [review]:

Thanks