GNOME Bugzilla – Bug 693981
subparse: fix bogus discontinuity detection if offset not set on buffers
Last modified: 2013-03-22 11:12:56 UTC
Created attachment 236400 [details] [review]
fix off by one offset calculation
Discontinuities are detected in the subparse buffer chain function, because the buffer offset is used even when invalid. This results in the subtitle parser being reset, and some subtitle lines are not shown.
The attached patch is a trivial fix.
The patch also removes the next_offset field which is not used.
Author: Arnaud Vrac <email@example.com>
Date: Thu Feb 14 01:35:45 2013 +0100
subparse: fix off by one offset calculation
Do not use the buffer start offset when it is invalid, otherwise a
discontinuity is detected on the next buffer, and the subtitle parser
reset and some subtitle lines are not shown.
Also remove unused next_offset field.