After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693974 - Fix some view transition glitches
Fix some view transition glitches
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-16 18:17 UTC by Cosimo Cecchi
Modified: 2013-02-16 18:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
overviewControls: reset translation as well when entering overview (779 bytes, patch)
2013-02-16 18:17 UTC, Cosimo Cecchi
committed Details | Review
overview: change _hideInProgress to visibleTarget (2.58 KB, patch)
2013-02-16 18:17 UTC, Cosimo Cecchi
committed Details | Review
viewSelector: don't use resetShowAppsButton when pressing escape (1.02 KB, patch)
2013-02-16 18:17 UTC, Cosimo Cecchi
committed Details | Review
viewSelector: always reset search string when entering overview (1.37 KB, patch)
2013-02-16 18:17 UTC, Cosimo Cecchi
committed Details | Review
viewSelector: make the old page fade-out optional (2.33 KB, patch)
2013-02-16 18:17 UTC, Cosimo Cecchi
committed Details | Review
viewSelector: block show apps button checked signal when resetting state (1.80 KB, patch)
2013-02-16 18:17 UTC, Cosimo Cecchi
committed Details | Review

Description Cosimo Cecchi 2013-02-16 18:17:20 UTC
Allan spotted some glitches in the new overview transitions. Here's a patchset that fixes those.
Comment 1 Cosimo Cecchi 2013-02-16 18:17:22 UTC
Created attachment 236382 [details] [review]
overviewControls: reset translation as well when entering overview
Comment 2 Cosimo Cecchi 2013-02-16 18:17:25 UTC
Created attachment 236383 [details] [review]
overview: change _hideInProgress to visibleTarget

And use it in overviewControls. When we moved this code from overview.js
to overviewControls.js we lost a condition so we now slide in controls
even when going back from the overview, which looks bad.
Comment 3 Cosimo Cecchi 2013-02-16 18:17:27 UTC
Created attachment 236384 [details] [review]
viewSelector: don't use resetShowAppsButton when pressing escape

Set the checked property explicitly. This is because
resetShowAppsButton() will only be used to flip the button state
blocking the page change in a future commit.
Comment 4 Cosimo Cecchi 2013-02-16 18:17:31 UTC
Created attachment 236385 [details] [review]
viewSelector: always reset search string when entering overview

Instead of relying on the apps button callback to do it for us.
Comment 5 Cosimo Cecchi 2013-02-16 18:17:34 UTC
Created attachment 236386 [details] [review]
viewSelector: make the old page fade-out optional

When leaving the overview, we don't want the old page to fade out, but
we want to fade in the windows directly.
Comment 6 Cosimo Cecchi 2013-02-16 18:17:36 UTC
Created attachment 236387 [details] [review]
viewSelector: block show apps button checked signal when resetting state

When we reset the state of the checked button due to the overview
showing and hiding, block the normal checked callback and immediately
switch to the workspaces page, so that windows seamlessly fade in.
Comment 7 Giovanni Campagna 2013-02-16 18:22:17 UTC
Review of attachment 236382 [details] [review]:

Ok
Comment 8 Giovanni Campagna 2013-02-16 18:22:55 UTC
Review of attachment 236383 [details] [review]:

Ok
Comment 9 Giovanni Campagna 2013-02-16 18:23:28 UTC
Review of attachment 236384 [details] [review]:

Ok
Comment 10 Giovanni Campagna 2013-02-16 18:24:10 UTC
Review of attachment 236385 [details] [review]:

Looks right.
Comment 11 Giovanni Campagna 2013-02-16 18:25:14 UTC
Review of attachment 236386 [details] [review]:

Ok (it looks bad to have a noFade argument, but I understand that you don't want to change every call site)
Comment 12 Giovanni Campagna 2013-02-16 18:25:54 UTC
Review of attachment 236387 [details] [review]:

Sure

(I had a similar fix somewhere)
Comment 13 Cosimo Cecchi 2013-02-16 18:27:01 UTC
Thanks for the quick review!

Attachment 236382 [details] pushed as 0705901 - overviewControls: reset translation as well when entering overview
Attachment 236383 [details] pushed as 31cdac7 - overview: change _hideInProgress to visibleTarget
Attachment 236384 [details] pushed as 1390cd4 - viewSelector: don't use resetShowAppsButton when pressing escape
Attachment 236385 [details] pushed as 1f1aba4 - viewSelector: always reset search string when entering overview
Attachment 236386 [details] pushed as 5f3b04e - viewSelector: make the old page fade-out optional
Attachment 236387 [details] pushed as d8b7ac9 - viewSelector: block show apps button checked signal when resetting state