GNOME Bugzilla – Bug 693974
Fix some view transition glitches
Last modified: 2013-02-16 18:27:19 UTC
Allan spotted some glitches in the new overview transitions. Here's a patchset that fixes those.
Created attachment 236382 [details] [review] overviewControls: reset translation as well when entering overview
Created attachment 236383 [details] [review] overview: change _hideInProgress to visibleTarget And use it in overviewControls. When we moved this code from overview.js to overviewControls.js we lost a condition so we now slide in controls even when going back from the overview, which looks bad.
Created attachment 236384 [details] [review] viewSelector: don't use resetShowAppsButton when pressing escape Set the checked property explicitly. This is because resetShowAppsButton() will only be used to flip the button state blocking the page change in a future commit.
Created attachment 236385 [details] [review] viewSelector: always reset search string when entering overview Instead of relying on the apps button callback to do it for us.
Created attachment 236386 [details] [review] viewSelector: make the old page fade-out optional When leaving the overview, we don't want the old page to fade out, but we want to fade in the windows directly.
Created attachment 236387 [details] [review] viewSelector: block show apps button checked signal when resetting state When we reset the state of the checked button due to the overview showing and hiding, block the normal checked callback and immediately switch to the workspaces page, so that windows seamlessly fade in.
Review of attachment 236382 [details] [review]: Ok
Review of attachment 236383 [details] [review]: Ok
Review of attachment 236384 [details] [review]: Ok
Review of attachment 236385 [details] [review]: Looks right.
Review of attachment 236386 [details] [review]: Ok (it looks bad to have a noFade argument, but I understand that you don't want to change every call site)
Review of attachment 236387 [details] [review]: Sure (I had a similar fix somewhere)
Thanks for the quick review! Attachment 236382 [details] pushed as 0705901 - overviewControls: reset translation as well when entering overview Attachment 236383 [details] pushed as 31cdac7 - overview: change _hideInProgress to visibleTarget Attachment 236384 [details] pushed as 1390cd4 - viewSelector: don't use resetShowAppsButton when pressing escape Attachment 236385 [details] pushed as 1f1aba4 - viewSelector: always reset search string when entering overview Attachment 236386 [details] pushed as 5f3b04e - viewSelector: make the old page fade-out optional Attachment 236387 [details] pushed as d8b7ac9 - viewSelector: block show apps button checked signal when resetting state