After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693940 - shell-keybinding-modes: Don't use expression references
shell-keybinding-modes: Don't use expression references
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-16 05:51 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-02-16 16:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shell-keybinding-modes: Don't use expression references (911 bytes, patch)
2013-02-16 05:51 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-02-16 05:51:40 UTC 
This confuses the gobject-introspection scanner, silently
making SHELL_KEYBINDING_MODE_NONE into -1.

--

An introspection bug has been filed with patches at bug #693939,
but this is a quick fix if we can't get that through the door in
time for GNOME 3.8.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-02-16 05:51:42 UTC 
Created attachment 236349 [details] [review]
shell-keybinding-modes: Don't use expression references

This confuses the gobject-introspection scanner, silently
making SHELL_KEYBINDING_MODE_NONE into -1.
Comment 2 Giovanni Campagna 2013-02-16 12:52:27 UTC 
Review of attachment 236349 [details] [review]:

It's probably the only case, but it actually looks better as ~0 to me!
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-02-16 16:45:10 UTC 
Attachment 236349 [details] pushed as 2df86e1 - shell-keybinding-modes: Don't use expression references