After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693923 - build: Don't fail to build if smbclient.pc can't be found
build: Don't fail to build if smbclient.pc can't be found
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-15 21:44 UTC by Jeremy Bicha
Modified: 2014-01-18 15:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Don't fail to build if smbclient.pc can't be found (1.57 KB, patch)
2013-02-15 21:44 UTC, Jeremy Bicha 		none Details | Review

Description Jeremy Bicha 2013-02-15 21:44:05 UTC 
Debian (& Ubuntu) unfortunately doesn't include smbclient.pc in their samba 
packaging. I filed http://bugs.debian.org/700643 for that, but meanwhile
this patch allows building gnome-control-center (although with the printing
panel disabled) on these systems.
Comment 1 Jeremy Bicha 2013-02-15 21:44:07 UTC 
Created attachment 236310 [details] [review]
build: Don't fail to build if smbclient.pc can't be found
Comment 2 Bastien Nocera 2013-02-18 08:46:48 UTC 
The patch broke the build when libsmbclient was available, as you didn't link the panel with it.
Comment 3 caribo 2013-03-01 11:26:54 UTC 
The latest gnome3 staging package (gnome-control-center 1:3.7.90-0ubuntu1~raring3) does not include the printers panel which I assume (rightly or wrongly) is related to this patch?
Comment 4 Jürg Billeter 2014-01-18 15:25:17 UTC 
(In reply to comment #3)
> The latest gnome3 staging package (gnome-control-center
> 1:3.7.90-0ubuntu1~raring3) does not include the printers panel which I assume
> (rightly or wrongly) is related to this patch?

If this is still an issue, see bug 722495.