After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693894 - COGL_TEST_ONSCREEN=0 results in onscreen conformance testing
COGL_TEST_ONSCREEN=0 results in onscreen conformance testing
Status: RESOLVED FIXED
Product: cogl
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Cogl maintainer(s)
Cogl maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-02-15 15:38 UTC by U. Artie Eoff
Modified: 2013-02-15 17:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description U. Artie Eoff 2013-02-15 15:38:36 UTC 
In tests/README, it states that COGL_TEST_ONSCREEN=1 can be set in your environment to enable onscreen testing for the conformance tests.  Logically, one would expect that this implies setting COGL_TEST_ONSCREEN=0 would "disable" onscreen testing.  However, this is not the case.  In fact, setting COGL_TEST_ONSCREEN to any value results in onscreen testing.

After looking at test/conform/test-utils.c, it is apparent why this behavior occurs:

if (getenv  ("COGL_TEST_ONSCREEN"))
{
...
}
else ...

The conditional is always true when COGL_TEST_ONSCREEN is set, regardless of it's value.

I propose that it should check the value of COGL_TEST_ONSCREEN and execute the conditional accordingly.

cogl (cogl-1.14) heads/cogl-1.14-0-gf79e78f
clutter (clutter-1.14) heads/clutter-1.14-0-g2ec89a6
Comment 1 Robert Bragg 2013-02-15 17:52:03 UTC 
Yeah this makes sense

I've just pushed a patch to master and cogl-1.14 to do as you proposed.

on master see: 25a8cf3607a482ca390eb9841295d1b365cbe53b
on cogl-1.14 see: 255b815f76c4281311b457e33c8b3bc6f4ff1534

thanks