After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693876 - More fixes for the doctool
More fixes for the doctool
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-02-15 11:48 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2015-02-07 16:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
girparser: Clean up code (1.46 KB, patch)
2013-02-15 11:48 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review
ast: Rename Class.parent to parent_type (5.74 KB, patch)
2013-02-15 11:48 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review
ast: Fall back to the namespace for the parent of a Node (1.02 KB, patch)
2013-02-15 11:48 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-02-15 11:48:50 UTC
Not 100% sure about the implementation, but I like the API cleanup.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-02-15 11:48:52 UTC
Created attachment 236232 [details] [review]
girparser: Clean up code

This makes it only use kwargs
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-02-15 11:48:55 UTC
Created attachment 236233 [details] [review]
ast: Rename Class.parent to parent_type

The eventual model I want to have is that .parent is the "container"
of the node. In all the cases where we don't explicitly set the parent,
this is the namespace, but having this under one field name would be
a big cleanup for the docwriter.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-02-15 11:48:57 UTC
Created attachment 236234 [details] [review]
ast: Fall back to the namespace for the parent of a Node
Comment 4 Dieter Verfaillie 2013-02-15 20:55:35 UTC
Review of attachment 236234 [details] [review]:

::: giscanner/ast.py
@@ +537,3 @@
+            return self.namespace
+
+    @parent.setter

.setter, .getter and .delete @property decorator attributes
are only introduced in Python 2.6 [1] but iirc walters needs
to support 2.5 for some old-ish rhel version.

[1] http://docs.python.org/2.6/whatsnew/2.6.html#other-language-changes
Comment 5 Dieter Verfaillie 2013-02-15 21:00:25 UTC
Review of attachment 236232 [details] [review]:

looks good to me, as both ast.Interface's and ast.Class' __init__() share the same signature
Comment 6 Dieter Verfaillie 2013-02-15 21:02:32 UTC
Review of attachment 236233 [details] [review]:

sounds like a good idea & patch looks good to me
Comment 7 Jasper St. Pierre (not reading bugmail) 2013-02-16 00:54:41 UTC
Attachment 236232 [details] pushed as df15906 - girparser: Clean up code
Attachment 236233 [details] pushed as 5ac33d8 - ast: Rename Class.parent to parent_type
Attachment 236234 [details] pushed as 50e99b6 - ast: Fall back to the namespace for the parent of a Node


pushed with suggested changes
Comment 8 André Klapper 2015-02-07 16:47:12 UTC
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]