GNOME Bugzilla – Bug 693876
More fixes for the doctool
Last modified: 2015-02-07 16:47:12 UTC
Not 100% sure about the implementation, but I like the API cleanup.
Created attachment 236232 [details] [review] girparser: Clean up code This makes it only use kwargs
Created attachment 236233 [details] [review] ast: Rename Class.parent to parent_type The eventual model I want to have is that .parent is the "container" of the node. In all the cases where we don't explicitly set the parent, this is the namespace, but having this under one field name would be a big cleanup for the docwriter.
Created attachment 236234 [details] [review] ast: Fall back to the namespace for the parent of a Node
Review of attachment 236234 [details] [review]: ::: giscanner/ast.py @@ +537,3 @@ + return self.namespace + + @parent.setter .setter, .getter and .delete @property decorator attributes are only introduced in Python 2.6 [1] but iirc walters needs to support 2.5 for some old-ish rhel version. [1] http://docs.python.org/2.6/whatsnew/2.6.html#other-language-changes
Review of attachment 236232 [details] [review]: looks good to me, as both ast.Interface's and ast.Class' __init__() share the same signature
Review of attachment 236233 [details] [review]: sounds like a good idea & patch looks good to me
Attachment 236232 [details] pushed as df15906 - girparser: Clean up code Attachment 236233 [details] pushed as 5ac33d8 - ast: Rename Class.parent to parent_type Attachment 236234 [details] pushed as 50e99b6 - ast: Fall back to the namespace for the parent of a Node pushed with suggested changes
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]