GNOME Bugzilla – Bug 693830
Ctrl + "+" doesn't zoom in
Last modified: 2014-08-12 00:35:48 UTC
Ctrl + "+" and Ctrl + "-" are the standard shortcuts for zoom in and zoom out. Currently, when previewing a document, Ctrl + "-" works, but Ctrl + "+" doesn't. I found that Ctrl + "=" is used instead, which I suppose makes life easier for en-US layout users, but makes no sense for pt-PT and probably others layouts.
We actually add both in Documents. This seems to be a bug in GtkApplication, where adding two different accelerators for the same action doesn't work.
*** This bug has been marked as a duplicate of bug 695917 ***
Reopening and reassigning back to gnome-documents because the original bug as described in comment 0 is still valid. See also bug 695917 comment 4 and bug 695917 comment 5.
*** Bug 711792 has been marked as a duplicate of this bug. ***
Created attachment 271492 [details] [review] Patch to handle multiple accels per action in _initAction it is now checked, if actionEntry.accel is an array, if so, the new function "set_accels_for_action()" is used.
Review of attachment 271492 [details] [review]: Thanks Daniel! This looks mostly good, with only some stylistic comment below. ::: application.js.bak @@ +248,3 @@ + if (actionEntry.accel){ + if (actionEntry.accel instanceof Array) { Indentation is off in the inner block here - should be four spaces. @@ +249,3 @@ + if (actionEntry.accel){ + if (actionEntry.accel instanceof Array) { + this.set_accels_for_action(action.print_detailed_name("app."+actionEntry.name,null),actionEntry.accel); Should use single quotes here and also spaces between "+" and "actionEntry". @@ +452,3 @@ { name: 'find-prev', accel: '<Shift><Primary>g', window_mode: WindowMode.WindowMode.PREVIEW }, + { name: 'zoom-in', accel: ['<Primary>plus','<Primary>equal'], I'm wondering if it wouldn't be better instead to special case the array to have a different "accels" property - but this is also OK.
I now pushed a slightly changed version of this patch with the proposed changes, since we're approaching hard code freeze.
*** Bug 734634 has been marked as a duplicate of this bug. ***