After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693822 - Fix detailed notifications in the lock screen
Fix detailed notifications in the lock screen
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: lock-screen
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-14 16:15 UTC by Giovanni Campagna
Modified: 2013-02-17 13:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
MessageTray: don't clear the banner text when adding to the body (2.16 KB, patch)
2013-02-14 16:15 UTC, Giovanni Campagna 		committed Details | Review
ScreenShield: don't add the source actor directly to the boxlayout (1.30 KB, patch)
2013-02-14 16:16 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2013-02-14 16:15:23 UTC 
See patches.
Comment 1 Giovanni Campagna 2013-02-14 16:15:50 UTC 
Created attachment 236092 [details] [review]
MessageTray: don't clear the banner text when adding to the body

ScreenShield uses Notification.bannerBodyText to fill the body of detailed
notifications, so use a separate boolean property to indicate it was already
added to the body.
Comment 2 Giovanni Campagna 2013-02-14 16:16:21 UTC 
Created attachment 236093 [details] [review]
ScreenShield: don't add the source actor directly to the boxlayout

StBoxLayout always fills on the orthogonal direction, so the icon
becomes distorted as the layout grows to accomodate more details.
Instead, use a bin that aligns at the start.
Comment 3 drago01 2013-02-17 13:33:21 UTC 
Review of attachment 236092 [details] [review]:

OK.
Comment 4 drago01 2013-02-17 13:33:37 UTC 
Review of attachment 236093 [details] [review]:

OK.
Comment 5 Giovanni Campagna 2013-02-17 13:55:55 UTC 
Attachment 236092 [details] pushed as 07676d4 - MessageTray: don't clear the banner text when adding to the body
Attachment 236093 [details] pushed as b45a2d7 - ScreenShield: don't add the source actor directly to the boxlayout