Created attachment 236063 [details] [review]
patch

can you attach screenies :)

I would if I could get the thing to run. :/

It was working earlier...

Created attachment 236665 [details]
screenie

Here is the screenshot with the two versions.

I am not going to apply the patch right now: I do not like either version, but the one with the gradient at least looks a little more subtle and finished.

In principle I really agree that the gradient is not in line with the general visual style we are using, but the version without gradients just looks tacky and improvised to me: it sounds like "let's take the first blue sky image we find and stick a transparent label on it. oh right, let's add rounded corner, just because we can!"


I think we should:
 * find better images (I know, I know, city images, but we still need default day/night images)
 * Maybe simply remove the label background (if the images are well picked so that the text is readable)
 * Use white text on blue background
 * Probably use larger thumbs
 * If we need to keep label background, remove the rounded corners and maybe try some other thing... I know I just said to remove the gradient, but a possibility would be a horizontal linear gradient that fades to transparent on the two sides

The gradient on the time really makes this look cheesy/clunky. I'll look into generic daytime/night backdrops.

Before we have the actual photo backdrop lookup feasible, just using flat colors wouldprobably be best -- https://raw.github.com/gnome-design-team/gnome-mockups/master/clocks/clocks-worldtime.png

We could use these generic backdrops too, to prepare for the specific location backdrops better -- https://raw.github.com/gnome-design-team/gnome-mockups/master/clocks/clocks-worldtime-photo.png

The flat color RGBA tinting will not be required for these, but will be to ensure the text is legible when we pull the images from a geolocation library of some sort.

This is now implemented on master. So stylish!

The only little thing that I could use some help with is how to make prelighting notiable in the night case....

We also need to figure out how to properly credit these images before closing this bug

For Getting Started, I've attributed sound samples in an AUTHORS file in the source. Maybe the about dialog should, instead of listing all photos, link to git.gnome.org / AUTHORS file and have that file link to specific photos.

Jakub: AUTHORS is surely a good start.


That said, can you remind me of who should I credit... I do not have the original link of the images

I redid the night version in Inkscape, so that one doesn't need a specific attribution and the daytime photo is based on CCBYSA2 licensed http://www.flickr.com/photos/60765633@N00/518084350/

Eek, I meant CCBY2

Okay, I added the AUTHORS file and put the attribution there... Also because the flickr account does not even have a real name to put in the about dialog.


Let's close this for now.