After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693780 - Settings dialog window titles
Settings dialog window titles
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
3.8.1?
Depends on:
Blocks:
 
 
Reported: 2013-02-14 10:35 UTC by Allan Day
Modified: 2013-04-15 12:27 UTC
See Also:
GNOME target: ---
GNOME version: 3.7/3.8

Attachments
network: Allow setting title on connection editor (2.84 KB, patch)
2013-04-13 02:05 UTC, Matthias Clasen 		committed Details | Review
network: Set the connection editor title for VPN (1.37 KB, patch)
2013-04-13 02:05 UTC, Matthias Clasen 		committed Details | Review
network: Set connection editor title for wired (2.38 KB, patch)
2013-04-13 02:05 UTC, Matthias Clasen 		committed Details | Review

Description Allan Day 2013-02-14 10:35:34 UTC 
The title of the network connection settings dialogs should either:

 * match whatever is in the interface list in the network panel, or
 * correspond to the wi-fi network name or wired profile (if there is more than one profile)

Currently, I get something different:

 * Wired - window title reads as "em1" (should be Wired)
 * VPN - window title reads "Red Hat" (should be "Red Hat VPN", as in the interface list)
Comment 1 Matthias Clasen 2013-04-13 02:05:20 UTC 
Created attachment 241431 [details] [review]
network: Allow setting title on connection editor

We want the title to match whats in the device list, which
sometimes does not match the connection id exactly. This
API lets us do so.
Comment 2 Matthias Clasen 2013-04-13 02:05:29 UTC 
Created attachment 241432 [details] [review]
network: Set the connection editor title for VPN
Comment 3 Matthias Clasen 2013-04-13 02:05:36 UTC 
Created attachment 241433 [details] [review]
network: Set connection editor title for wired
Comment 4 Bastien Nocera 2013-04-15 08:24:58 UTC 
Review of attachment 241431 [details] [review]:

Looks good.

::: panels/network/connection-editor/net-connection-editor.c
@@ +978,3 @@
+void
+net_connection_editor_set_title (NetConnectionEditor *editor,
+                                 const gchar         *title)

Would we need to reset the title for some things?
I'd special case a NULL title for that case.
Comment 5 Bastien Nocera 2013-04-15 08:25:28 UTC 
Review of attachment 241432 [details] [review]:

::: panels/network/net-vpn.c
@@ +413,3 @@
                                             vpn->priv->connection,
                                             NULL, NULL, client, settings);
+        title = g_strdup_printf (_("%s VPN"), nm_connection_get_id (vpn->priv->connection));

Missing translator comments.
Comment 6 Bastien Nocera 2013-04-15 08:27:19 UTC 
Review of attachment 241433 [details] [review]:

Looks fine otherwise.

::: panels/network/net-device-ethernet.c
@@ +281,3 @@
+show_details_for_wired (GtkButton *button, NetDeviceEthernet *device)
+{
+        show_details (button, device, _("Wired"));

Translator comments missing
Comment 7 Matthias Clasen 2013-04-15 12:27:35 UTC 
Attachment 241431 [details] pushed as 7618df7 - network: Allow setting title on connection editor
Attachment 241432 [details] pushed as 58a09ae - network: Set the connection editor title for VPN
Attachment 241433 [details] pushed as 2e626e0 - network: Set connection editor title for wired