Created attachment 235985 [details] [review]
use sys/types.h in numbers.h

While here I am attaching another patch required for FreeBSD.

This is on gnumeric 1.12.0 BTW.

MAXDOUBLE fixed -- it should have been G_MAXDOUBLE.

Why do you need sys/types.h?

Comment on attachment 235985 [details] [review]
use sys/types.h in numbers.h

Hmm..
That patch was not mine, it was in the legacy port.
I just ran the build without that patch and it goes fine. Perhaps there was some warning otr something that is now clean. Doesn't matter :).

Thanks!

ok -- please let me know if anything else prevents compilation.
Just in case, I would recommend to do something like

    make clean
    make 2>&1 | tee error.log

and inspect error.log for warnings about missing prototypes.  Those can
lead to pretty nasty surprises later, especially on 64-bit.

Hello Morten;

I am trying to compile with the patch you committed but I see a problem with line 33:

#include <values.h>

This header doesn't exist on FreeBSD. You can ifdef it but if you don't need it anymore, I suggest just to remove it.

Removed.