After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693756 - loginDialog: fix cancel from "Not Listed?"
loginDialog: fix cancel from "Not Listed?"
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: login-screen
unspecified
Other All
: Normal normal
: ---
Assigned To: Ray Strode [halfline]
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-14 02:30 UTC by Ray Strode [halfline]
Modified: 2015-05-02 15:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
loginDialog: fix cancel from "Not Listed?" (29.14 KB, patch)
2013-02-14 02:30 UTC, Ray Strode [halfline] 		committed Details | Review

Description Ray Strode [halfline] 2013-02-14 02:30:03 UTC 
Since commit 1ae0fadbf483128e27565baba6e8684bc5defca2 we
no longer start a PAM conversation as soon as the user clicks
the "Not Listed?" button.  Instead we defer starting the PAM
conversation until the user types their username.

Unfortunately, the cancel button resets the dialog back to the
user list indrectly by cancelling the current PAM conversation.

This means if the user hasn't yet entered thier username then
the cancel button doesn't work.

This commit performs a direct dialog reset in the case the
PAM conversation hasn't been started yet.
Comment 1 Ray Strode [halfline] 2013-02-14 02:30:06 UTC 
Created attachment 235977 [details] [review]
loginDialog: fix cancel from "Not Listed?"
Comment 2 Giovanni Campagna 2013-02-14 12:47:41 UTC 
Review of attachment 235977 [details] [review]:

Looks good.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-02-14 16:08:39 UTC 
Review of attachment 235977 [details] [review]:

Eek. I'm not sure I like one path being an implicit result of the cancel, and another calling _reset. I think having one _reset function call do everything is a good idea.
Comment 4 Giovanni Campagna 2013-02-14 16:17:09 UTC 
The problem is that GDM sometimes emits a Reset on its own, for example for a successful switching.
Comment 5 Ray Strode [halfline] 2013-02-19 01:35:30 UTC 
Attachment 235977 [details] pushed as 7da186d - loginDialog: fix cancel from "Not Listed?"
Comment 6 Juraj Fiala 2015-05-02 15:47:11 UTC 
I still experience this.