After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693750 - Riffmedia doesn't set systemstream=false for some video/mpeg caps
Riffmedia doesn't set systemstream=false for some video/mpeg caps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-13 23:57 UTC by Matej Knopp
Modified: 2013-02-14 10:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (2.56 KB, patch)
2013-02-13 23:57 UTC, Matej Knopp 		committed Details | Review

Description Matej Knopp 2013-02-13 23:57:11 UTC 
Created attachment 235969 [details] [review]
Patch

Which breaks playback as decoders require systemstream=false in caps
Comment 1 Tim-Philipp Müller 2013-02-14 00:18:30 UTC 
I would say this is a bug in the decoder.

As far as I know we have never used systemstream=true/false for mpeg4 caps, caps for mp4 are different and not video/mpeg. It's only used for mpeg1/2 video.

But I can see it in gstavcodecmap.c of course.
Comment 2 Tim-Philipp Müller 2013-02-14 00:22:33 UTC 
Hrm, fascinating, it's all over the place, and goes way back. Not sure what it's good for though.
Comment 3 Matej Knopp 2013-02-14 01:26:00 UTC 
Can't really answer that, all I can tell is that without systemstream I get warnings from pbutils descriptions and parser and encoders fail to link. 

MPEG 4 video parser seems to have systemstream=false in caps from the very beginning.
Comment 4 Sebastian Dröge (slomo) 2013-02-14 09:59:47 UTC 
I don't know why it exists either but everything all over the place is expecting it. We might want to remove it in 2.0 though.

commit 5385a65b043ca222c6396e31dac22ab1b7f1d13b
Author: Matej Knopp <matej.knopp@gmail.com>
Date:   Wed Feb 13 23:28:01 2013 +0100

    riffmedia: add systemstream to all mpeg video caps