After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693749 - Allow changing the page of a presentation
Allow changing the page of a presentation
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
3.8?
Depends on:
Blocks: 691255
 
 
Reported: 2013-02-13 22:54 UTC by William Jon McCann
Modified: 2013-02-28 18:48 UTC
See Also:
GNOME target: 3.8
GNOME version: ---


Attachments
Allow changing the page of a presentation (2.82 KB, patch)
2013-02-13 22:54 UTC, William Jon McCann
committed Details | Review
A different approach (2.66 KB, patch)
2013-02-19 16:35 UTC, Carlos Garcia Campos
none Details | Review

Description William Jon McCann 2013-02-13 22:54:41 UTC
This allows using a separate control process to change the pages. We
would like to use this in Documents so that the main window can remotely
control the presentation window.
Comment 1 William Jon McCann 2013-02-13 22:54:43 UTC
Created attachment 235960 [details] [review]
Allow changing the page of a presentation
Comment 2 Carlos Garcia Campos 2013-02-18 16:09:12 UTC
Isn't it enough with ev_view_presentation_next|previous_page() to control the presentation remotely? Do you really need to jump to any random page in a presentation? Note that transitions won't work with your patch when you go to the next page by changing the current page property.
Comment 3 William Jon McCann 2013-02-18 17:26:10 UTC
Yes, we need the random access. I think not having the transitions is ok for now.
Comment 4 Carlos Garcia Campos 2013-02-19 16:35:52 UTC
Created attachment 236787 [details] [review]
A different approach

Would this patch work for you too?
Comment 5 William Jon McCann 2013-02-22 20:20:40 UTC
Not really. Can you explain how this is fundamentally different from my patch? Or how mine doesn't do animations?
Comment 6 Carlos Garcia Campos 2013-02-23 10:34:22 UTC
(In reply to comment #5)
> Not really. 

Why not?

> Can you explain how this is fundamentally different from my patch?

Your patch makes a read only property writable.

> Or how mine doesn't do animations?

It does, I was wrong.
Comment 7 William Jon McCann 2013-02-25 14:29:55 UTC
We already have a property and we are already using it from Documents. It seems much cleaner to just continue to use the property instead of adding another method that does exactly the same thing.
Comment 8 Carlos Garcia Campos 2013-02-28 18:29:56 UTC
Fair enough, I guess it's easier for bindings to use the property.
Comment 9 Carlos Garcia Campos 2013-02-28 18:30:21 UTC
Review of attachment 235960 [details] [review]:

Please push it, thanks!
Comment 10 William Jon McCann 2013-02-28 18:48:30 UTC
Attachment 235960 [details] pushed as 53d6a3f - Allow changing the page of a presentation