GNOME Bugzilla – Bug 693749
Allow changing the page of a presentation
Last modified: 2013-02-28 18:48:34 UTC
This allows using a separate control process to change the pages. We would like to use this in Documents so that the main window can remotely control the presentation window.
Created attachment 235960 [details] [review] Allow changing the page of a presentation
Isn't it enough with ev_view_presentation_next|previous_page() to control the presentation remotely? Do you really need to jump to any random page in a presentation? Note that transitions won't work with your patch when you go to the next page by changing the current page property.
Yes, we need the random access. I think not having the transitions is ok for now.
Created attachment 236787 [details] [review] A different approach Would this patch work for you too?
Not really. Can you explain how this is fundamentally different from my patch? Or how mine doesn't do animations?
(In reply to comment #5) > Not really. Why not? > Can you explain how this is fundamentally different from my patch? Your patch makes a read only property writable. > Or how mine doesn't do animations? It does, I was wrong.
We already have a property and we are already using it from Documents. It seems much cleaner to just continue to use the property instead of adding another method that does exactly the same thing.
Fair enough, I guess it's easier for bindings to use the property.
Review of attachment 235960 [details] [review]: Please push it, thanks!
Attachment 235960 [details] pushed as 53d6a3f - Allow changing the page of a presentation