After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693732 - Debug messages are not printed even if G_MESSAGES_DEBUG=all is set
Debug messages are not printed even if G_MESSAGES_DEBUG=all is set
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: shell
git master
Other Linux
: Normal minor
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-13 17:58 UTC by Emanuele Aina
Modified: 2013-02-13 18:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shell: Do not forcibly suppress debug messages if --verbose not set (1.17 KB, patch)
2013-02-13 17:59 UTC, Emanuele Aina 		committed Details | Review
shell: Do not forcibly suppress debug messages if --verbose not set (1.17 KB, patch)
2013-02-13 18:19 UTC, Emanuele Aina 		committed Details | Review

Description Emanuele Aina 2013-02-13 17:58:15 UTC 
If the --verbose flag has not been specified cc_shell_log_set_debug() forces G_MESSAGES_DEBUG=all but then decides that G_LOG_LEVEL_DEBUG messages should be ignored, even if an appropriate G_MESSAGES_DEBUG variable was already available in the environment.

This means that running `G_MESSAGES_DEBUG=all gnome-control-center' will not print any debug message from gnome-control-center, which is quite unexpected.
Comment 1 Emanuele Aina 2013-02-13 17:59:48 UTC 
Created attachment 235934 [details] [review]
shell: Do not forcibly suppress debug messages if --verbose not set

Only force G_MESSAGES_DEBUG=all on --verbose, and follow the usual
logging behaviour otherwise.

This fixes specifying log domains in G_MESSAGES_DEBUG and also
G_MESSAGES_DEBUG=all without setting --verbose.
Comment 2 Bastien Nocera 2013-02-13 18:12:33 UTC 
Review of attachment 235934 [details] [review]:

Looks fine.
Comment 3 Emanuele Aina 2013-02-13 18:18:55 UTC 
The following fix has been pushed:
30144e5 shell: Do not forcibly suppress debug messages if --verbose not set
Comment 4 Emanuele Aina 2013-02-13 18:19:02 UTC 
Created attachment 235939 [details] [review]
shell: Do not forcibly suppress debug messages if --verbose not set

Only force G_MESSAGES_DEBUG=all on --verbose, and follow the usual
logging behaviour otherwise.

This fixes specifying log domains in G_MESSAGES_DEBUG and also
G_MESSAGES_DEBUG=all without setting --verbose.