After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693689 - Add a Tasks interface and make it work with the Google provider
Add a Tasks interface and make it work with the Google provider
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks: 652132
 
 
Reported: 2013-02-13 03:22 UTC by Felipe Borges
Modified: 2014-06-20 09:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] Add a Tasks interface and make it work with the Google provider (8.76 KB, patch)
2013-02-13 03:22 UTC, Felipe Borges
reviewed Details | Review
google: Add support for tasks (1.05 KB, patch)
2014-06-19 09:45 UTC, Debarshi Ray
none Details | Review
google: Add support for tasks (1.16 KB, patch)
2014-06-19 09:49 UTC, Debarshi Ray
none Details | Review
google: Add support for tasks (1.16 KB, patch)
2014-06-19 11:32 UTC, Debarshi Ray
none Details | Review
google: Update README (1.14 KB, patch)
2014-06-19 11:33 UTC, Debarshi Ray
committed Details | Review
google: Add support for tasks (1.64 KB, patch)
2014-06-19 11:34 UTC, Debarshi Ray
committed Details | Review

Description Felipe Borges 2013-02-13 03:22:37 UTC
Created attachment 235862 [details] [review]
[PATCH] Add a Tasks interface and make it work with the Google provider

Hey,

Google Tasks[0] is one of my favorite Google Apps. It's simple, easy-to-use and fully integrated with GMail.

One can imagine, in the near future, a GNOME App to manage tasks (using GOA to sync with Google).

The attached patch adds a Task interface to GOA and makes it work w/ the Google provider.

[0] https://mail.google.com/mail/help/tasks/
Comment 1 Debarshi Ray 2013-02-13 14:24:33 UTC
Review of attachment 235862 [details] [review]:

Thanks for the patch. You also need to bump the value returned by get_credentials_generation so that the older OAuth2 token is replaced by a new one that has the permission to access Google Tasks.

However, we first need the application before we can commit this. Advertising Tasks to the user, without actually doing something with it is pointless.
Comment 2 Milan Crha 2013-03-04 16:14:00 UTC
Google and CalDAV for tasks:
http://code.google.com/p/google-caldav-issues/issues/detail?id=36

An alternative is their API for it, but it means to use other providers/backends/whatever, instead of CalDAV, which is possible to use for events, only not for Tasks.
Comment 3 Debarshi Ray 2014-06-19 09:45:04 UTC
Created attachment 278751 [details] [review]
google: Add support for tasks

After talking to mcrha on IRC, we decided to club tasks and calendars under the same switch for the time being. I like it this way because:
 - they are so similar to each other
 - the switches generally correspond to the name of a core GNOME app (evolution is an exception) - while there are standalone apps for calendars, I don't know of a tasks app
 - the number of switches that we have for Google is already quite big and I don't want to clutter the UI with a long list of [ON|OFF] buttons

If this does not work out well, we will add a separate switch for tasks later.
Comment 4 Debarshi Ray 2014-06-19 09:49:41 UTC
Created attachment 278752 [details] [review]
google: Add support for tasks

Forgot to bump the credentials generation.
Comment 5 Debarshi Ray 2014-06-19 11:32:09 UTC
Created attachment 278756 [details] [review]
google: Add support for tasks

As far as I can make out the OAuth2 scope string is undocumented. Lets mention that.
Comment 6 Debarshi Ray 2014-06-19 11:33:01 UTC
Created attachment 278757 [details] [review]
google: Update README
Comment 7 Debarshi Ray 2014-06-19 11:34:19 UTC
Created attachment 278758 [details] [review]
google: Add support for tasks
Comment 8 Debarshi Ray 2014-06-19 11:38:50 UTC
Review of attachment 278757 [details] [review]:

Committed.
Comment 9 Debarshi Ray 2014-06-19 11:39:23 UTC
Review of attachment 278758 [details] [review]:

Committed after testing with mcrha.
Comment 10 Debarshi Ray 2014-06-19 11:41:44 UTC
Review of attachment 235862 [details] [review]:

The scope for tasks is now in master, but the bits that add a switch and interface are not. We will revisit that in future.