After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693658 - Use sidecar files for plug-ins
Use sidecar files for plug-ins
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: librygel-core
git master
Other Linux
: Normal enhancement
: ---
Assigned To: rygel-maint
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-12 16:19 UTC by Jens Georg
Modified: 2016-04-12 19:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
all: Add sidecar file support for plugins (24.68 KB, patch)
2013-04-24 12:16 UTC, Jens Georg
committed Details | Review

Description Jens Georg 2013-02-12 16:19:52 UTC
This enables us to not even load the plugin if it's disabled and prevent loading of concurrent versions of e.g. GStreamer.

Currently disabled plug-ins are not even unloaded and we can only know if the plugin should be enabled/disabled upon loading it
Comment 1 Jens Georg 2013-02-12 16:31:58 UTC
With "sidecar" meaning some accompanying text file describing the plug-in's properties.
Comment 2 Jens Georg 2013-02-14 08:47:58 UTC
should be enhancement, not trivial
Comment 3 Jens Georg 2013-04-24 12:16:40 UTC
Created attachment 242318 [details] [review]
all: Add sidecar file support for plugins

Install a .plugin file with each plugin that provides some meta-information
about the plugin, allowing us to not load the module if the user has disabled
it instead blindly loading each .so we come across and let the module check
whether it's enabled or not
Comment 4 Krzesimir Nowak 2013-04-25 08:12:44 UTC
Review of attachment 242318 [details] [review]:

Found two typos.

::: src/librygel-core/rygel-plugin-information.vala
@@ +24,3 @@
+ * Parse plugin sidecar file and provide path to the module.
+ *
+ * Sidecar files are keyfiles, losely compatible with the files used by

s/losely/loosely

@@ +27,3 @@
+ * libpeas.
+ *
+ * A minimum file looks like this:

s/minimum/minimal
Comment 5 Jens Georg 2013-04-30 10:44:30 UTC
Comment on attachment 242318 [details] [review]
all: Add sidecar file support for plugins

Patch committed with comments fixed

Attachment 242318 [details] pushed as a68c54a - all: Add sidecar file support for plugins
Comment 6 Krzesimir Nowak 2013-04-30 10:56:18 UTC
Heh, removed two typos just to add a new one. :)

"A minimal file for the plugin librygel-sompelugin.so looks like this:"
                                        ^^^^^^^^^^
Comment 7 Jens Georg 2013-04-30 11:04:55 UTC
Well, good ratio, it goes down ;)
Comment 8 Jussi Kukkonen 2014-03-28 08:46:53 UTC
This fails make install for me: gtk-doc fails to use {{{ and }}} as code block markers properly. I get a </programlisting> end marker without a start marker in the xml. As a result the html is not generated.

The docs for gtk-doc seem to say |[ and ]| are the right way to mark code blocks... that fixes make install but for some reason I end up with the whole example in one single code line. Grrr.
Comment 9 Jussi Kukkonen 2014-03-28 08:56:41 UTC
And the bug link I should have included: bug 727219