After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693657 - network: Improve accessibility in network popups
network: Improve accessibility in network popups
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-12 16:08 UTC by Jeremy Bicha
Modified: 2013-02-12 23:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
network: Add more mnemonic_widget relations for accessibility (30.23 KB, patch)
2013-02-12 16:08 UTC, Jeremy Bicha 		needs-work Details | Review
network: Add accessibile labels to buttons in the popup dialogs (9.04 KB, patch)
2013-02-12 16:33 UTC, Jeremy Bicha 		committed Details | Review
network: Set mnemonic labels for editable text fields for a11y (15.44 KB, patch)
2013-02-12 16:38 UTC, Jeremy Bicha 		committed Details | Review
network: Add more mnemonic_widget relations for accessibility (6.38 KB, patch)
2013-02-12 16:43 UTC, Jeremy Bicha 		committed Details | Review

Description Jeremy Bicha 2013-02-12 16:08:32 UTC 
Here's 3 patches to improve accessibility in the network popup dialogs
Comment 1 Jeremy Bicha 2013-02-12 16:08:33 UTC 
Created attachment 235784 [details] [review]
network: Add more mnemonic_widget relations for accessibility
Comment 2 Bastien Nocera 2013-02-12 16:10:33 UTC 
Review of attachment 235784 [details] [review]:

Half of the modified files here are from the color panel.
Comment 3 Jeremy Bicha 2013-02-12 16:33:08 UTC 
Created attachment 235787 [details] [review]
network: Add accessibile labels to buttons in the popup dialogs
Comment 4 Jeremy Bicha 2013-02-12 16:38:20 UTC 
Created attachment 235789 [details] [review]
network: Set mnemonic labels for editable text fields for a11y

I've seen a bug where Orca will stop reading labels for some of these fields
after I navigate around enough. I don't know if that's a problem with this code
or what. I feel more comfortable with .ui files doing the right thing.
Comment 5 Jeremy Bicha 2013-02-12 16:43:13 UTC 
Created attachment 235793 [details] [review]
network: Add more mnemonic_widget relations for accessibility

Here's a cleaned up version of the first patch, sorry about that :)
Comment 6 Matthias Clasen 2013-02-12 22:16:14 UTC 
Review of attachment 235793 [details] [review]:

Looks fine
Comment 7 Matthias Clasen 2013-02-12 22:20:18 UTC 
Review of attachment 235787 [details] [review]:

looks fine
Comment 8 Matthias Clasen 2013-02-12 22:23:19 UTC 
Review of attachment 235789 [details] [review]:

sure
Comment 9 Jeremy Bicha 2013-02-12 23:07:37 UTC 
Attachment 235787 [details] pushed as 5ed961f - network: Add accessibile labels to buttons in the popup dialogs
Attachment 235789 [details] pushed as 7061457 - network: Set mnemonic labels for editable text fields for a11y
Attachment 235793 [details] pushed as 5cbc89d - network: Add more mnemonic_widget relations for accessibility