After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693655 - Add a test for delayed loading of tabs
Add a test for delayed loading of tabs
Status: RESOLVED OBSOLETE
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-12 16:07 UTC by Gustavo Noronha (kov)
Modified: 2018-08-03 19:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Adds test for delayed loading of tabs (6.58 KB, patch)
2013-02-12 16:09 UTC, Gustavo Noronha (kov) 		none Details | Review
Test using some instrumentation to help out (6.58 KB, patch)
2013-02-15 01:50 UTC, Gustavo Noronha (kov) 		none Details | Review
Test using some instrumentation to help out (7.66 KB, patch)
2013-02-15 16:10 UTC, Gustavo Noronha (kov) 		needs-work Details | Review

Description Gustavo Noronha (kov) 2013-02-12 16:07:25 UTC 
Delayed loading of tabs upon session restore has been implemented, but we still need to figure out how to get it tested, since it relies on the EphyEmbed being mapped, which is something we don't do for tests right now.

See https://bugzilla.gnome.org/show_bug.cgi?id=675302
Comment 1 Gustavo Noronha (kov) 2013-02-12 16:09:15 UTC 
Created attachment 235785 [details] [review]
Adds test for delayed loading of tabs

Here's what I have currently, we need to figure out whether we want to do this with xvfb or think of a different strategy.
Comment 2 Gustavo Noronha (kov) 2013-02-15 01:50:44 UTC 
Created attachment 236204 [details] [review]
Test using some instrumentation to help out

How about something like this? I feel this properly duplicates the behaviour we have now, though we may have to revisit when we move away from tabs. But then again, I guess we will have to rework all of this code for that, anyway.
Comment 3 Gustavo Noronha (kov) 2013-02-15 16:10:24 UTC 
Created attachment 236261 [details] [review]
Test using some instrumentation to help out

Oops, uploaded the wrong patch yesterday. doh
Comment 4 Michael Catanzaro 2015-09-11 03:00:53 UTC 
Review of attachment 236261 [details] [review]:

Going through old patches....

I don't like adding extra code for tests, but this is much better than using Xvfb, so I think it's fine. The patch needs rebased though.
Comment 5 GNOME Infrastructure Team 2018-08-03 19:49:38 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/epiphany/issues/187.