After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693653 - sharing: add a master switch to allow disabling of all services
sharing: add a master switch to allow disabling of all services
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Sharing
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-12 14:55 UTC by Thomas Wood
Modified: 2013-02-19 10:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
sharing: add a master switch to allow disabling of all services (7.58 KB, patch)
2013-02-12 14:55 UTC, Thomas Wood
needs-work Details | Review
sharing: add a master switch to allow disabling of all services (9.65 KB, patch)
2013-02-18 18:15 UTC, Thomas Wood
none Details | Review

Description Thomas Wood 2013-02-12 14:55:47 UTC
Add a master switch to allow disabling of all services.
Comment 1 Thomas Wood 2013-02-12 14:55:49 UTC
Created attachment 235778 [details] [review]
sharing: add a master switch to allow disabling of all services
Comment 2 Bastien Nocera 2013-02-12 16:21:36 UTC
Got the UI mockup for this?
Comment 3 Thomas Wood 2013-02-14 09:59:06 UTC
(In reply to comment #2)
> Got the UI mockup for this?

https://live.gnome.org/Design/SystemSettings/Sharing

The mockups do not show the "Enabled" string, but I have added it to be consistent with other panels that have this feature (e.g. Search). I expect this to change when the panel titles appear in the toolbar (bug 692174).
Comment 4 Bastien Nocera 2013-02-18 09:11:33 UTC
Review of attachment 235778 [details] [review]:

UI looks good, but the error paths aren't working so well.

I have "Personal File Sharing", "Screen Sharing" and "Remote Login" all "On".

Clicking on the switch asks me for my password to disable the remote login. If this fails, all the services but "remote login" are disabled and the switch stays "Enabled". The error path should include restoring the services to their prior state (and possible start by disabling the ones that can fail).
Comment 5 Thomas Wood 2013-02-18 18:15:47 UTC
Created attachment 236644 [details] [review]
sharing: add a master switch to allow disabling of all services
Comment 6 Thomas Wood 2013-02-18 18:47:15 UTC
(In reply to comment #5)
> Created an attachment (id=236644) [details] [review]
> sharing: add a master switch to allow disabling of all services

This patch adds restoring services to their previous state if the master switch is re-activated.
Comment 7 Thomas Wood 2013-02-19 10:05:28 UTC
The patch pushed does not include re-enabling of services, since the user may
not expect the services to be enabled after one of them failed to be disabled.

The patch also has the "Enabled" label removed, since bug 692174 has now been
resolved.