GNOME Bugzilla – Bug 693650
User account panel - issues with hint texts
Last modified: 2014-05-29 17:00:22 UTC
Created attachment 235777 [details] screenshot The hint texts are misaligned (they should have the same horizontal alignment). They should also be dimmed (ie. grey). Screenshot is attached.
Created attachment 245042 [details] slight re-arrange This would fix #700319 as well, any thoughts?
Created attachment 245046 [details] [review] account: Re-arrange the layout so that the hint texts align better This means that the longer translations for hints do not resize the window and that the hint texts are aligned correctly to the input texts.
With strength label/level moved up: http://i.imgur.com/wTpx5XN.png
Working on changes to be corresponding with g-c-c user accounts panel.
Created attachment 274461 [details] [review] account: design changes of local part Design changes are done according mockup. It corresponds with User Accounts panel in Gnome Control Center. Use checkmarks to indicate correct values instead of checkmarks. Alignment of hints is changed. Hints are dimmed and dynamic.
Created attachment 274462 [details] screenshots of the redesigned page
Review of attachment 274461 [details] [review]: Design looks good. "Use checkmarks to indicate correct values instead of checkmarks" ? ::: gnome-initial-setup/pages/account/um-utils.c @@ +242,3 @@ if (!empty && (in_use || too_long || !valid)) { if (in_use) { + *tip = g_strdup_printf (_("A user with the username '%s' already exists."), I assume these string changes come from g-c-c and have been acked by the designers ?
Thanks for the review. (In reply to comment #7) > Review of attachment 274461 [details] [review]: > > Design looks good. "Use checkmarks to indicate correct values instead of > checkmarks" ? ...instead of stop signs. Will fix it later. > ::: gnome-initial-setup/pages/account/um-utils.c > @@ +242,3 @@ > if (!empty && (in_use || too_long || !valid)) { > if (in_use) { > + *tip = g_strdup_printf (_("A user with the username > '%s' already exists."), > > I assume these string changes come from g-c-c and have been acked by the > designers ? Most of the code is copied/inspired from the g-c-c, however I've changed those strings to have '.' at the end. In g-c-c there is: hint = g_strdup_printf ("%s.", tip). Would be better to do that also this way, to have identical code in um-utils.c and same strings for translation? Would be best to share those codes with g-c-c and don't have it twice, however not sure, how to do that...
(In reply to comment #8) > Most of the code is copied/inspired from the g-c-c, however I've changed those > strings to have '.' at the end. In g-c-c there is: hint = g_strdup_printf > ("%s.", tip). Would be better to do that also this way, to have identical code > in um-utils.c and same strings for translation? Yes. The "%s." is terrible anyway, because some languages might not use periods for punctuation anyway, or they might not be at the end of a string.
(In reply to comment #6) > Created an attachment (id=274462) [details] > screenshots of the redesigned page The colour and alignment of the text in the screenshot looks good. Is the text new? Where did it come from?
(In reply to comment #9) > (In reply to comment #8) > > Most of the code is copied/inspired from the g-c-c, however I've changed those > > strings to have '.' at the end. In g-c-c there is: hint = g_strdup_printf > > ("%s.", tip). Would be better to do that also this way, to have identical code > > in um-utils.c and same strings for translation? > > Yes. The "%s." is terrible anyway, because some languages might not use periods > for punctuation anyway, or they might not be at the end of a string. I have filed new bug to sync text into g-c-c: https://bugzilla.gnome.org/show_bug.cgi?id=728870 (In reply to comment #10) > (In reply to comment #6) > > Created an attachment (id=274462) [details] [details] > > screenshots of the redesigned page > > The colour and alignment of the text in the screenshot looks good. Is the text > new? Where did it come from? Text isn't new. Text comes from g-c-c, see the Add User dialog :-) Some of them was there before and some of them are from yours mockups: https://github.com/gnome-design-team/gnome-mockups/blob/master/system-settings/users/add-user-account.png
Comment on attachment 274461 [details] [review] account: design changes of local part commit 86aa54c56edb8d48a3e34e859f8de99d4d553668