After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693634 - autoreconf fails with 1.15.3 on missing m4 directory
autoreconf fails with 1.15.3 on missing m4 directory
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: build
1.15.x
Other Linux
: Normal normal
: ---
Assigned To: Tomas Bzatek
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-12 05:44 UTC by Martin Pitt
Modified: 2013-03-22 14:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Distribute m4 macros (1.16 KB, patch)
2013-02-12 16:41 UTC, Tomas Bzatek 		committed Details | Review

Description Martin Pitt 2013-02-12 05:44:47 UTC 
Since 1.15.3, autoreconf fails with

$ LANG= autoreconf 
aclocal: couldn't open directory 'm4': No such file or directory
autoreconf: aclocal failed with exit status: 1

This is apparently because of this part in Makefile.am

   -ACLOCAL_AMFLAGS = ${ACLOCAL_FLAGS}
   +ACLOCAL_AMFLAGS = -I m4 ${ACLOCAL_FLAGS}

in http://git.gnome.org/browse/gvfs/commit/?id=fdbe5dd3f.

It helps to either revert that bit, or actually add an empty m4/ directory (and dist it).
Comment 1 Tomas Bzatek 2013-02-12 16:41:07 UTC 
Created attachment 235792 [details] [review]
build: Distribute m4 macros

Attaching proposed patch, not sure if this is the right way, I'm not autotools expert. Please test.

Looking at other Gnome components, they tend to use gnome-autogen.sh which takes care of everything. They're also distributing the m4 directory with bunch of macros there.
Comment 2 Martin Pitt 2013-02-12 16:47:04 UTC 
Comment on attachment 235792 [details] [review]
build: Distribute m4 macros

That helps as well, thanks! Tested on current master with "make dist", unpacking the tarball, and autoreconf -fv.
Comment 3 Emilio Pozuelo Monfort 2013-03-05 16:01:53 UTC 
autogen.sh should probably be disted as well.
Comment 4 Martin Pitt 2013-03-06 10:40:18 UTC 
Can we push this patch? 1.15.4 was released without this.
Comment 5 Tomas Bzatek 2013-03-20 15:31:52 UTC 
(In reply to comment #3)
> autogen.sh should probably be disted as well.

No, autogen{.sh} is not supposed to be included in tarball and we don't usually do this. If user wants to do serious development, cloning git repo is the preferred way.

(In reply to comment #4)
> Can we push this patch? 1.15.4 was released without this.

Oops, forgot about this before leaving on vacation in all the rush. Going to request hard code freeze break.
Comment 6 Tomas Bzatek 2013-03-22 14:12:41 UTC 
commit 12630fb340785422d3d52e8d832413590856b193
Author: Tomas Bzatek <tbzatek@redhat.com>
Date:   Fri Mar 22 15:09:55 2013 +0100

    build: Distribute m4 macros
    
    The m4 directory is used by *ize scripts for putting their m4 macros there
    and is a common practice to distribute these macros within a tarball.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=693634