After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693572 - Child popup menu regression
Child popup menu regression
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-11 08:04 UTC by Florian Müllner
Modified: 2013-02-18 18:31 UTC
See Also:
GNOME target: 3.8
GNOME version: ---

Attachments
popupMenu: Move child menus to be a PopupMenu-only thing (2.60 KB, patch)
2013-02-16 18:44 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
popupMenu: Close all child menus when the main menu is closed (927 bytes, patch)
2013-02-16 18:44 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
popupMenu: Remove support for nested combo boxes (1.19 KB, patch)
2013-02-18 01:02 UTC, Jasper St. Pierre (not reading bugmail) 		none Details | Review
popupMenu: Remove support for nested combo boxes (1.08 KB, patch)
2013-02-18 18:25 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Florian Müllner 2013-02-11 08:04:14 UTC 
Some fallout from the GrabHelper port:

(1) Click user name
(2) Click presence combo box
(3) Click user name again

Expected behavior:
Both user menu and combobox popup are closed.

Actual behavior:
The combobox popup stays open.
Comment 1 Matthias Clasen 2013-02-12 04:03:30 UTC 
ugly regression belongs on the 3.8 list
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-02-16 18:44:07 UTC 
Created attachment 236395 [details] [review]
popupMenu: Move child menus to be a PopupMenu-only thing

It doesn't make sense for combo menus, sections, or submenus
to have child menus.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-02-16 18:44:14 UTC 
Created attachment 236396 [details] [review]
popupMenu: Close all child menus when the main menu is closed

Otherwise, if something managed to call close(), it wouldn't
close any child menus.
Comment 4 Giovanni Campagna 2013-02-17 17:57:20 UTC 
Review of attachment 236395 [details] [review]:

If you do this, you should change also getTopMenu in PopupComboBoxMenuItem to recurse into PopupComboMenus
Comment 5 Giovanni Campagna 2013-02-17 17:58:33 UTC 
Review of attachment 236396 [details] [review]:

Looks good.
Comment 6 Jasper St. Pierre (not reading bugmail) 2013-02-18 01:02:47 UTC 
Created attachment 236516 [details] [review]
popupMenu: Remove support for nested combo boxes

I'm sure this was originally a testcase for nested child
menus, and we never actually inteded any support for this.
Comment 7 Jasper St. Pierre (not reading bugmail) 2013-02-18 18:25:01 UTC 
Created attachment 236647 [details] [review]
popupMenu: Remove support for nested combo boxes

I'm sure this was originally a testcase for nested child
menus, and we never actually inteded any support for this.
Comment 8 Giovanni Campagna 2013-02-18 18:26:39 UTC 
Review of attachment 236647 [details] [review]:

Yes.

(And acn to the previous one too)
Comment 9 Giovanni Campagna 2013-02-18 18:26:40 UTC 
Review of attachment 236647 [details] [review]:

Yes.

(And acn to the previous one too)
Comment 10 Jasper St. Pierre (not reading bugmail) 2013-02-18 18:31:30 UTC 
Attachment 236395 [details] pushed as c9783b3 - popupMenu: Move child menus to be a PopupMenu-only thing
Attachment 236396 [details] pushed as 809295c - popupMenu: Close all child menus when the main menu is closed
Attachment 236647 [details] pushed as 44e4cbf - popupMenu: Remove support for nested combo boxes