After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693548 - build: Only use G*_DISABLE_DEPRECATED flags with GTK2
build: Only use G*_DISABLE_DEPRECATED flags with GTK2
Status: RESOLVED FIXED
Product: easytag
Classification: Other
Component: general
master
Other All
: Normal normal
: 2.1
Assigned To: EasyTAG maintainer(s)
EasyTAG maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-02-10 20:21 UTC by Florian Müllner
Modified: 2013-02-10 21:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Only use G*_DISABLE_DEPRECATED flags with GTK2 (1.42 KB, patch)
2013-02-10 20:21 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2013-02-10 20:21:27 UTC 
Currently easytag fails to build for me when specifying --with-gtk3; see attached patch for a quick-n-dirty fix.
Comment 1 Florian Müllner 2013-02-10 20:21:30 UTC 
Created attachment 235644 [details] [review]
build: Only use G*_DISABLE_DEPRECATED flags with GTK2

For now, the code has only been updated to not use any deprecated
GTK+-2 API to ease porting to GTK+-3; API that has only been
deprecated in GTK+-3 is still in use, so don't use those flags
when building with --with-gtk3.
Comment 2 David King 2013-02-10 21:14:24 UTC 
Review of attachment 235644 [details] [review]:

Good idea, please push.
Comment 3 Florian Müllner 2013-02-10 21:16:41 UTC 
Attachment 235644 [details] pushed as ae44533 - build: Only use G*_DISABLE_DEPRECATED flags with GTK2