After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693485 - Use GdRevealer for sliding in the find bar
Use GdRevealer for sliding in the find bar
Status: RESOLVED FIXED
Product: gnome-system-log
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: gnome-system-log-maint
gnome-system-log-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-09 17:59 UTC by Carl-Anton Ingmarsson
Modified: 2013-02-11 19:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Update to latest libgd (543 bytes, patch)
2013-02-09 17:59 UTC, Carl-Anton Ingmarsson 		committed Details | Review
Use GdRevealer for sliding in the find bar (2.80 KB, patch)
2013-02-09 17:59 UTC, Carl-Anton Ingmarsson 		committed Details | Review

Description Carl-Anton Ingmarsson 2013-02-09 17:59:50 UTC 
See the attached patches.

Patch two implements this by separately instantiating the
GdRevealer in LogviewWindow. Perhaps it's cleaner to make
LogviewFindbar a subclass of GdRevealer instead?
Comment 1 Carl-Anton Ingmarsson 2013-02-09 17:59:52 UTC 
Created attachment 235593 [details] [review]
Update to latest libgd
Comment 2 Carl-Anton Ingmarsson 2013-02-09 17:59:54 UTC 
Created attachment 235594 [details] [review]
Use GdRevealer for sliding in the find bar
Comment 3 Cosimo Cecchi 2013-02-11 19:13:17 UTC 
Attachment 235593 [details] pushed as ed87f3c - Update to latest libgd
Attachment 235594 [details] pushed as d3fde6a - Use GdRevealer for sliding in the find bar

Thanks for the patches! I pushed these to master after a little change I made to the revealer API today.