GNOME Bugzilla – Bug 693450
tests/registry.c needs installed plugins
Last modified: 2018-09-24 09:21:15 UTC
I was looking into enabling the test suite during build in Ubuntu (https://bugs.launchpad.net/ubuntu/+source/grilo/+bug/1119781). But I ran into several problems. 1) In configure.ac: -AM_CONDITIONAL(ENABLE_TESTS, test "enable_tests" = "xyes") +AM_CONDITIONAL(ENABLE_TESTS, test "x$enable_tests" = "xyes") 2) In tests/registry.c: - GrlMediaPlugin *source = GRL_MEDIA_PLUGIN (sources_iter->data); + GrlSource *source = GRL_SOURCE (sources_iter->data); 3) tests/metadata_source.c needs a rethink, since the filter functions are no longer public. 4) tests/registry.c seems to need the package to have been installed, as it looks in the install location for plugins. Is this expected? (Not a deal breaker for using the tests in Ubuntu, but is not as convenient.) I didn't test the python tests yet, but I'm guessing they may have bit-rotten as well.
Yes, mostly the tests in Grilo core are broken or unmaintained. Something we need to take care, for sure.
(In reply to Michael Terry from comment #0) > I was looking into enabling the test suite during build in Ubuntu > (https://bugs.launchpad.net/ubuntu/+source/grilo/+bug/1119781). > > But I ran into several problems. > > 1) In configure.ac: > -AM_CONDITIONAL(ENABLE_TESTS, test "enable_tests" = "xyes") > +AM_CONDITIONAL(ENABLE_TESTS, test "x$enable_tests" = "xyes") commit a05a65f34ba36f44a3e06390c6806727f7454dfa Author: Bastien Nocera <hadess@hadess.net> Date: Wed Sep 2 13:54:12 2015 +0200 build: Fix tests enablements Spotted by Michael Terry <michael.terry@canonical.com> https://bugzilla.gnome.org/show_bug.cgi?id=693450 > 2) In tests/registry.c: > - GrlMediaPlugin *source = GRL_MEDIA_PLUGIN (sources_iter->data); > + GrlSource *source = GRL_SOURCE (sources_iter->data); That was done in: https://bugzilla.gnome.org/show_bug.cgi?id=748455 > 3) tests/metadata_source.c needs a rethink, since the filter functions are > no longer public. Got removed as well. > 4) tests/registry.c seems to need the package to have been installed, as it > looks in the install location for plugins. Is this expected? (Not a deal > breaker for using the tests in Ubuntu, but is not as convenient.) Indeed. Retitling the bug as that's the only issue left.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/grilo/issues/25.