GNOME Bugzilla – Bug 693437
places-menu: Make 'network' volume handling more Nautilus-like
Last modified: 2013-02-09 20:34:27 UTC
While trying out the new GOA volume monitor (bug 686526) with an ownCloud account, I noticed that 'network' volumes without a mount are not shown. We should still show them like Nautilus, because when a user adds a new account, the storage associated with the account is exposed as a volume but the volume is not immediately mounted to cut down on network traffic. The volume is only mounted when the user tries to access it. (The GVfs bits are still rough. So clicking the volume in Nautilus leads to a separate entry for the mount. Also, if you click the volume in the places-menu, you will notice an exception caused by a null mount. It could be a GVfs bug too, I am not sure.)
Created attachment 235530 [details] [review] places-menu: Make 'network' volume handling more Nautilus-like Let me know if you need a test ownCloud account to test this.
Review of attachment 235530 [details] [review]: Ok, but with a minor style nit. ::: extensions/places-menu/placeDisplay.js @@ +242,3 @@ + networkVolumes.push(volumes[i]); + continue; + } I'd prefer a if (...) { } else { } here (and same in the the next loop).
Comment on attachment 235530 [details] [review] places-menu: Make 'network' volume handling more Nautilus-like Thanks! Changed as suggested and committed.