GNOME Bugzilla – Bug 693435
eds test: create-remove-stores fails sporadically
Last modified: 2018-09-21 16:00:37 UTC
It's not clear exactly why, but the eds test create-remove-stores fails about 15% when run through gdb manually. It fails 100% of the time during a regular "make check" for at least all of eds.
Created attachment 235528 [details] [review] Fix the test by ensuring our sources are declared as enabled (as e-d-s does itself) Patch from branch: http://cgit.collabora.com/git/user/treitter/folks.git/log/?h=bgo693435-fix-create-remove-stores (If this commit appears, just ignore it; I've removed it locally: "CUT -- temporarily disable flakey telepathy test")
Hrm, I have managed to reproduce the problem a couple times even with this patch. But it still significantly reduces its frequency (again, for no apparent reason). So it's still worth applying. I think there's something race going on on the EDS side that should be fixed (if it's invalid to exclude an Enabled line we should get an error earlier anyhow). CC'ing Matthew in case he's got any insight. Here's the relevant ESource setup function: http://git.gnome.org/browse/folks/tree/tests/lib/eds/backend.vala#n147 (this is before the patch has been applied as of this writing)
Exactly where is the test failing? Is there a GError / warning message, or just an assertion tripping?
Created attachment 235549 [details] Test failure backtrace Sorry, I thought I included this originally. Anything else I can provide, Matthew?
Created attachment 235559 [details] Test failure backtrace Sorry, not sure what happened that I ended up with broken HTML. Here's the actual backtrace.
That looks pretty deep in GDBus code. An internal hash table lookup in GDBusObjectManagerClient is coming up empty for some reason. The only removals on that hash table are in on_notify_g_name_owner() and further down in the same function where the warning is being issued. Maybe it's being called twice for the same object path? Nothing really E-D-S specific about any of this that I can see.
Review of attachment 235528 [details] [review]: ++
Comment on attachment 235528 [details] [review] Fix the test by ensuring our sources are declared as enabled (as e-d-s does itself) Applied - I'm leaving this bug open because it doesn't seem to be 100% fixed by this patch.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/folks/issues/52.