After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693395 - can't input common Korean toggle key combination for input source switch shortcut
can't input common Korean toggle key combination for input source switch shor...
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Keyboard
3.7.x
Other Linux
: Normal major
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
3.10
: 695372 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-02-08 03:31 UTC by sangu
Modified: 2013-04-22 04:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch; Allow input of Hangul and Shift-space for shortcut (1.03 KB, patch)
2013-02-13 03:02 UTC, Changwoo Ryu
none Details | Review
proposed patch; Allow input of Hangul and Shift-space for shortcut (1005 bytes, patch)
2013-02-13 23:11 UTC, Changwoo Ryu
reviewed Details | Review
keyboard: Allow input of Hangul and Modifier+space shortcuts (1.46 KB, patch)
2013-04-03 06:17 UTC, Changwoo Ryu
committed Details | Review

Description sangu 2013-02-08 03:31:10 UTC
Input source switch uses Hangul key or shift + space key in Korea.

Then,  only ctrl+space key can be used in gnome 3.6 and gnome 3.7.5

When selecting  aonther keys in Keyboard - Typing - Switch to next source or Switch to previous source

"The shortcut "Shift+Space" cannot be used because it will become impossible to type using this key.
Please try with a key such as Control, Alt or Shift at the same time."

"The shortcut "Hangul" cannot be used because it will become impossible to type using this key.
Please try with a key such as Control, Alt or Shift at the same time."

---
gnome-settings-daemon-3.7.5-1.fc19.x86_64
control-center-3.7.5-1.fc19.x86_64
gnome-shell-3.7.5-2.fc19.x86_64
Comment 1 André Klapper 2013-02-08 07:13:19 UTC
Hi sangu,
what is the bug that you describe here?
Comment 2 sangu 2013-02-08 08:18:26 UTC
I cannot change input source switch shortcuts ( like a hangul key or shift + space key) in gnome-control-center keyboard.
Comment 3 André Klapper 2013-02-08 08:36:44 UTC
That's intentional for Shift+Space and the Hangul, as the error message says that you posted. Is the shown error message unclear, or why did you post a bug report here?
Comment 4 Seong-ho, Cho 2013-02-08 10:12:49 UTC
Hello, I'm co-translator of the GNOME Korea localization team.
before we discuss about this issue we need to explain about
"how many Korean uses shift+space key combination"
and 
"how much they need to use this feature".

we've discussed similar problem in below thread 
https://bugzilla.gnome.org/show_bug.cgi?id=682319

many Korean is using native word processor "Hangul 20xx" for Windows
made by Hancom company from about 25 years ago. and they're 
very familiar to use shift+space key combination,
because this is just TRADITIONAL feature in that program.
so, as they said, we(Korean) usually use a key combination shift + space
to change input mode, and sangu also said his opinion similar to above link.
most of all users are use the generic 101 key layout, 
rather than some specific keyboard layout such as like "HHKB Pro 2". 

so we are not comfortable to use ctrl+space more than shift+space.

of course, we also use right Alt key as "Korean/English" which can be alternated from shift + space.
"right-Alt-use" issue also discussed above thread.
therefore, I'm STRONGLY tell you about this issue :) please consider our opinion and suggestion to add some feature for adding key combination in another way.
Comment 5 Rui Matos 2013-02-08 10:44:01 UTC
Ok, thanks for the report. I'll find a way to fix this for 3.8 .
Comment 6 Changwoo Ryu 2013-02-13 03:02:07 UTC
Created attachment 235861 [details] [review]
proposed patch; Allow input of Hangul and Shift-space for shortcut

It just allows the common Hangul switch key combinations.
Comment 7 Changwoo Ryu 2013-02-13 23:11:05 UTC
Created attachment 235966 [details] [review]
proposed patch; Allow input of Hangul and Shift-space for shortcut

Clean up the patch
Comment 8 Rui Matos 2013-04-02 08:10:28 UTC
Review of attachment 235966 [details] [review]:

I'm sorry but this can't work as explained in https://bugzilla.gnome.org/show_bug.cgi?id=695823#c3 .
Comment 9 Rui Matos 2013-04-02 08:10:55 UTC

*** This bug has been marked as a duplicate of bug 695823 ***
Comment 10 Rui Matos 2013-04-02 23:56:51 UTC
*** Bug 695372 has been marked as a duplicate of this bug. ***
Comment 11 Rui Matos 2013-04-02 23:57:50 UTC
Review of attachment 235966 [details] [review]:

I changed my mind, I think we should do this.
Comment 12 Rui Matos 2013-04-03 00:00:50 UTC
Review of attachment 235966 [details] [review]:

Actually, can you provide a git patch including a commit summary and message?
Comment 13 Changwoo Ryu 2013-04-03 06:17:24 UTC
Created attachment 240464 [details] [review]
keyboard: Allow input of Hangul and Modifier+space shortcuts

Includes commit message
Comment 14 Rui Matos 2013-04-03 12:55:56 UTC
Review of attachment 240464 [details] [review]:

Great, thank you. Looks good
Comment 15 Changwoo Ryu 2013-04-22 04:27:29 UTC
committed on master

commit 4888729aaea6934582ff3aee60dd3ee3d7a0e72a
Author: Changwoo Ryu <cwryu@debian.org>
Date:   Wed Apr 3 15:00:02 2013 +0900

    keyboard: Allow input of Hangul and Modifier+space shortcuts
    
    These keyboard switching key combinations had been rejected because
    using them as shortcuts might prevent users from inputting text. But
    now the input source switching keys are configured and processed in
    GNOME. So the shortcut settings should allow these key combinations.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=693395