After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693357 - network: fix some alignment issues
network: fix some alignment issues
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-07 20:08 UTC by Cosimo Cecchi
Modified: 2013-02-11 16:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
network: fix some alignment issues (3.00 KB, patch)
2013-02-07 20:08 UTC, Cosimo Cecchi 		committed Details | Review
network: add some spacing between rows (2.53 KB, patch)
2013-02-07 21:01 UTC, Cosimo Cecchi 		committed Details | Review
network: unfuzzy symbolic buttons and make them square (7.42 KB, patch)
2013-02-07 21:25 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2013-02-07 20:08:18 UTC 
See attached patch
Comment 1 Cosimo Cecchi 2013-02-07 20:08:19 UTC 
Created attachment 235442 [details] [review]
network: fix some alignment issues

If you click the sections in the left side treeview, some of the
elements in the right page headers will move a couple of pixels.
Also, since the WPAD warning label was always visible, the alignment of
the controls section in the Proxy page was suboptimal.
Comment 2 Cosimo Cecchi 2013-02-07 21:01:52 UTC 
Created attachment 235450 [details] [review]
network: add some spacing between rows

In the IPv4/IPv6 pages the grid packing address controls has no spacing
at all.
Comment 3 Cosimo Cecchi 2013-02-07 21:25:17 UTC 
Created attachment 235452 [details] [review]
network: unfuzzy symbolic buttons and make them square

Use the 'image-button' style class to make symbolic buttons square
(as supported by latest Adwaita), and make sure to use the correct icon
size for all symbolics to avoid fuzzyness.
Comment 4 Bastien Nocera 2013-02-11 13:31:57 UTC 
Review of attachment 235442 [details] [review]:

Looks good.
Comment 5 Bastien Nocera 2013-02-11 13:32:31 UTC 
Review of attachment 235450 [details] [review]:

++
Comment 6 Bastien Nocera 2013-02-11 13:34:07 UTC 
Review of attachment 235452 [details] [review]:

++
Comment 7 Cosimo Cecchi 2013-02-11 16:44:02 UTC 
Attachment 235442 [details] pushed as c0242f2 - network: fix some alignment issues
Attachment 235450 [details] pushed as 2acd6a5 - network: add some spacing between rows
Attachment 235452 [details] pushed as 0969b36 - network: unfuzzy symbolic buttons and make them square