After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693346 - apps-menu: Few clean ups
apps-menu: Few clean ups
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-07 17:18 UTC by Debarshi Ray
Modified: 2013-02-08 12:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
apps-menu: Clean up code (1.16 KB, patch)
2013-02-07 17:19 UTC, Debarshi Ray 		committed Details | Review
apps-menu: Clean up code (3.04 KB, patch)
2013-02-07 17:20 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2013-02-07 17:18:18 UTC 
A random assortment of cleanups. Should not have any behavioural changes.
Comment 1 Debarshi Ray 2013-02-07 17:19:48 UTC 
Created attachment 235427 [details] [review]
apps-menu: Clean up code
Comment 2 Debarshi Ray 2013-02-07 17:20:23 UTC 
Created attachment 235428 [details] [review]
apps-menu: Clean up code
Comment 3 Debarshi Ray 2013-02-07 17:20:57 UTC 
Do you want me to squash them? Easier to squash than split, so I kept them separate.
Comment 4 Giovanni Campagna 2013-02-08 08:04:08 UTC 
Bah, squash and then push them.
Comment 5 Debarshi Ray 2013-02-08 12:26:00 UTC 
Thanks. Pushed as:

commit c626cc2a1d412ef1000d2c74860bd19fb5711971
Author: Debarshi Ray <debarshir@gnome.org>
Date:   Fri Feb 1 14:51:25 2013 +0100

    apps-menu: Clean up code
    
    The empty array is created and inserted into the hashtable before
    every call to _loadCategory. No need to check for it and create it
    again inside the function.
    
    Don't mix up negated if conditions with continue while skipping stuff
    that should not be displayed. Follow one style for consistency.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=693346