After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693338 - wayland: skip pointer and keyboard events without a surface
wayland: skip pointer and keyboard events without a surface
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-02-07 15:39 UTC by Thomas Wood
Modified: 2013-02-12 15:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wayland: skip pointer and keyboard events without a surface (1.88 KB, patch)
2013-02-07 15:39 UTC, Thomas Wood 		committed Details | Review

Description Thomas Wood 2013-02-07 15:39:36 UTC 
Pointer and keyboard events can be received after the surface has been
destroyed, in which case the surface will be NULL.
Comment 1 Thomas Wood 2013-02-07 15:39:38 UTC 
Created attachment 235418 [details] [review]
wayland: skip pointer and keyboard events without a surface

Pointer and keyboard events can be received after the surface has been
destroyed, in which case the surface will be NULL.
Comment 2 Matthias Clasen 2013-02-11 03:08:18 UTC 
Review of attachment 235418 [details] [review]:

looks fine to me, but I'm not a wayland expert
Comment 3 Rob Bradford 2013-02-11 10:12:01 UTC 
Review of attachment 235418 [details] [review]:

Yes. We need to do this since after the object has been destroyed in the client i.e. wl_surface_destroy the compositor may still send events for that object. Since the object has been destroyed the client library doesn't know what proxy (client side representation of remote object) to map the integer object id to so it uses NULL for the object pointer.
Comment 4 Thomas Wood 2013-02-12 15:46:45 UTC 
Attachment 235418 [details] pushed as bfd7137 - wayland: skip pointer and keyboard events without a surface