After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693334 - apps-menu: Set use_markup and label_actor
apps-menu: Set use_markup and label_actor
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
3.7.x
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-07 15:03 UTC by Debarshi Ray
Modified: 2013-02-08 12:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Desktop file with & (302 bytes, application/octet-stream)
2013-02-07 15:03 UTC, Debarshi Ray 		  Details
apps-menu: Set use_markup and label_actor (991 bytes, patch)
2013-02-07 15:05 UTC, Debarshi Ray 		reviewed Details | Review
apps-menu: Clean up mark up handling and set label_actor (1.74 KB, patch)
2013-02-07 17:15 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2013-02-07 15:03:49 UTC 
Created attachment 235408 [details]
Desktop file with &

If a desktop file has & in its Name, then the character is not displayed properly unless use_markup is set.

I believe, we should also set label_actor for accessibility.
Comment 1 Debarshi Ray 2013-02-07 15:05:24 UTC 
Created attachment 235411 [details] [review]
apps-menu: Set use_markup and label_actor
Comment 2 Giovanni Campagna 2013-02-07 15:42:30 UTC 
Review of attachment 235411 [details] [review]:

Don't you need to escape the ampersand as & if you set has_markup?
Comment 3 Debarshi Ray 2013-02-07 17:14:23 UTC 
(In reply to comment #2)
> Review of attachment 235411 [details] [review]:
> 
> Don't you need to escape the ampersand as & if you set has_markup?

That is what fixMarkup does.

I had somehow convinced myself during the early days of the AxeMenu that fixMarkup is required, but it turns out that it is not. So we can just get rid of fixMarkup instead.
Comment 4 Debarshi Ray 2013-02-07 17:15:09 UTC 
Created attachment 235426 [details] [review]
apps-menu: Clean up mark up handling and set label_actor
Comment 5 Giovanni Campagna 2013-02-08 08:02:47 UTC 
Review of attachment 235426 [details] [review]:

Much better
Comment 6 Giovanni Campagna 2013-02-08 08:02:48 UTC 
Review of attachment 235426 [details] [review]:

Much better
Comment 7 Debarshi Ray 2013-02-08 12:30:08 UTC 
Thanks for the review.