GNOME Bugzilla – Bug 693333
Last modified: 2013-02-18 11:27:03 UTC
Allow creating a contact from details with specific groups.
Created attachment 235406 [details] [review]
groups from details
Review of attachment 235406 [details] [review]:
Looks good to me. Please commit this with a NEWS entry, then make a separate commit with the fix mentioned below. Thanks!
@@ +537,1 @@
this._set_contact_is_favourite (contact, is_fav);
Hmm. This won’t make the contact a member of the “Starred in Android” group. Perhaps we should be calling _set_is_favourite() here instead? Could you fix that in a separate commit please?
(In reply to comment #2)
> Looks good to me. Please commit this with a NEWS entry, then make a separate
> commit with the fix mentioned below.
Okay, done. I missed the 0.9.1 release, though.