After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693333 - groups support
groups support
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: e-d-s backend
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-07 14:43 UTC by Patrick Ohly
Modified: 2013-02-18 11:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
groups from details (2.38 KB, patch)
2013-02-07 14:44 UTC, Patrick Ohly 		committed Details | Review

Description Patrick Ohly 2013-02-07 14:43:54 UTC 
Allow creating a contact from details with specific groups.
Comment 1 Patrick Ohly 2013-02-07 14:44:25 UTC 
Created attachment 235406 [details] [review]
groups from details
Comment 2 Philip Withnall 2013-02-12 00:07:14 UTC 
Review of attachment 235406 [details] [review]:

Looks good to me. Please commit this with a NEWS entry, then make a separate commit with the fix mentioned below. Thanks!

::: backends/eds/lib/edsf-persona-store.vala
@@ +537,1 @@
               this._set_contact_is_favourite (contact, is_fav);

Hmm. This won’t make the contact a member of the “Starred in Android” group. Perhaps we should be calling _set_is_favourite() here instead? Could you fix that in a separate commit please?
Comment 3 Patrick Ohly 2013-02-18 11:26:52 UTC 
(In reply to comment #2)
> Looks good to me. Please commit this with a NEWS entry, then make a separate
> commit with the fix mentioned below.

Okay, done. I missed the 0.9.1 release, though.