After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693330 - Consistently use GdNotification
Consistently use GdNotification
Status: RESOLVED FIXED
Product: gnome-contacts
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Contacts maintainer(s)
GNOME Contacts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-02-07 14:29 UTC by Cosimo Cecchi
Modified: 2013-02-07 15:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
app: consistently use GdNotification (1.68 KB, patch)
2013-02-07 14:30 UTC, Cosimo Cecchi
none Details | Review
Remove unused GtkNotification copy (36.55 KB, patch)
2013-02-07 14:30 UTC, Cosimo Cecchi
none Details | Review

Description Cosimo Cecchi 2013-02-07 14:29:59 UTC
See attached patches
Comment 1 Cosimo Cecchi 2013-02-07 14:30:00 UTC
Created attachment 235404 [details] [review]
app: consistently use GdNotification

Always use the notification widget from libgd instead of our own
internal copy.
Comment 2 Cosimo Cecchi 2013-02-07 14:30:03 UTC
Created attachment 235405 [details] [review]
Remove unused GtkNotification copy

We always use the object from libgd now.
Comment 3 Erick Perez Castellanos 2013-02-07 15:43:00 UTC
Pushed to master: http://git.gnome.org/browse/gnome-contacts/commit/?id=ed4589c9ee48f676a29d7d3b6f0c9549480c6966