GNOME Bugzilla – Bug 693326
Handle long names better
Last modified: 2013-04-26 15:50:46 UTC
Created attachment 235399 [details] Screenshot While playing with how ellipsizing works in gnome-shell, I stumbled upon this (see screenshot). Maybe we should be wrapping really long names into multiple lines because this increases the horizontal width of the window.
Created attachment 239561 [details] [review] width_chars, max_width_chars and ellipsize properties Add width_chars, max_width_chars and ellipsize properties for cc-editable-entry.
Created attachment 239562 [details] [review] ellipsize long names Set width_chars, max_width_chars and ellipsize for names.
Created attachment 239563 [details] screenshot with ellipsize
(In reply to comment #3) > Created an attachment (id=239563) [details] > screenshot with ellipsize Looks good!
Review of attachment 239561 [details] [review]: I think part of this patch is missing since only the header file is modified here.
yes it looks this is a 2 files patch , where is part 2 ? Subject: [PATCH 1/2] cc-editable-entry: Add width_chars, max_width_chars and
Created attachment 241884 [details] [review] width_chars, max_width_chars and ellipsize properties Hopefully there is patch with all changes :-)
Review of attachment 241884 [details] [review]: Is it actually a 2 files patch ? (PATCH 1/2) cc-editable-entry: Add width_chars, max_width_chars and ellipsize properties
(In reply to comment #8) > Review of attachment 241884 [details] [review]: Could you please avoid reviewing and changing the status of patches? This is especially bad as the part of the subject line that's in brackets will be stripped when it's applied by git, so your question doesn't make sense.
Review of attachment 241884 [details] [review]: Looks good to me, please push to master and gnome-3-8 branches.
Review of attachment 239562 [details] [review]: Looks fine, please commit to master and gnome-3-8 branches after reviewing the spacing change. ::: panels/user-accounts/data/user-accounts-dialog.ui @@ +54,3 @@ <object class="GtkHBox" id="hbox2"> <property name="visible">True</property> + <property name="spacing">18</property> Was this change intentional?
(In reply to comment #11) > Review of attachment 239562 [details] [review]: > > Looks fine, please commit to master and gnome-3-8 branches after reviewing the > spacing change. I'll commit it soon. > ::: panels/user-accounts/data/user-accounts-dialog.ui > @@ +54,3 @@ > <object class="GtkHBox" id="hbox2"> > <property name="visible">True</property> > + <property name="spacing">18</property> > > Was this change intentional? Yes, because if user has really long name, full-name-entry is too wide and there is no spacing between scrolled window and labels...
It is commited to the both branches...