GNOME Bugzilla – Bug 693303
Various patches to the keyboard status icon
Last modified: 2013-02-07 10:44:18 UTC
The first two are sort of a cleanup -- I found that inputSourcesChanged was getting called twice. Not that big of a deal, but seemed like we should be able to do less. When doing that, I tested to see how well the XKB-only path worked, and found as far as I can tell the only issue with it. Nice work on that one. The last one is a removal for set_skip_paint, which I want to trash soon.
Created attachment 235352 [details] [review] keyboard: Fake out the readyCallback if we don't have IBus This allows us to move to one initialization code path if we only have XKB.
Created attachment 235353 [details] [review] keyboard: Don't call inputSourcesChanged on init IBusManager will call inputSourcesChanged when the engine is registered, even if we don't have IBus.
Created attachment 235354 [details] [review] keyboard: Make sure to set currentSource if we only have one source This way, popping up and re-closing the switcher won't emit an error trying to check for this._currentSource.
Created attachment 235355 [details] [review] keyboard: Don't use set_skip_paint
(In reply to comment #0) > The first two are sort of a cleanup -- I found that inputSourcesChanged > was getting called twice. Not that big of a deal, but seemed like we > should be able to do less. You're claiming that it's being called twice when !IBus, i.e. when ibus is not even installed? I can't see how that could happen. Can you get stack traces?
Review of attachment 235353 [details] [review]: If we do have ibus then the panel menu won't show up until we hear back from ibus-daemon which might take a while at session start.
(In reply to comment #5) > You're claiming that it's being called twice when !IBus, i.e. when ibus is not > even installed? I can't see how that could happen. Can you get stack traces? No, only when IBus is installed. There's once from the _init, and another from when the IBus engine starts up.
(In reply to comment #7) > (In reply to comment #5) > > You're claiming that it's being called twice when !IBus, i.e. when ibus is not > > even installed? I can't see how that could happen. Can you get stack traces? > > No, only when IBus is installed. There's once from the _init, and another from > when the IBus engine starts up. Right, that's for reasons I explained in the patch review above.
Review of attachment 235354 [details] [review]: ++
Review of attachment 235355 [details] [review]: Ok
Attachment 235354 [details] pushed as 997f851 - keyboard: Make sure to set currentSource if we only have one source Attachment 235355 [details] pushed as c0e5719 - keyboard: Don't use set_skip_paint