After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693297 - Addd ephy_session_clear()
Addd ephy_session_clear()
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 128184
 
 
Reported: 2013-02-07 08:25 UTC by Claudio Saavedra
Modified: 2013-02-07 22:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ephy-session.c: add ephy_session_clear() (1.53 KB, patch)
2013-02-07 08:25 UTC, Claudio Saavedra
committed Details | Review
ephy-session-test: add test for ephy_session_clear() (4.10 KB, patch)
2013-02-07 08:25 UTC, Claudio Saavedra
committed Details | Review

Description Claudio Saavedra 2013-02-07 08:25:15 UTC
We need this to properly test the tab restoring code.
Comment 1 Claudio Saavedra 2013-02-07 08:25:17 UTC
Created attachment 235348 [details] [review]
ephy-session.c: add ephy_session_clear()
Comment 2 Claudio Saavedra 2013-02-07 08:25:20 UTC
Created attachment 235349 [details] [review]
ephy-session-test: add test for ephy_session_clear()
Comment 3 Xan Lopez 2013-02-07 17:06:25 UTC
Review of attachment 235348 [details] [review]:

::: src/ephy-session.h
@@ +105,3 @@
 gboolean         ephy_session_get_can_undo_tab_closed (EphySession *session);
 
+void             ephy_session_clear                   (EphySession *session);

Put this in ephy-private.h, it really only makes sense for testing IMHO.
Comment 4 Xan Lopez 2013-02-07 17:06:51 UTC
Review of attachment 235349 [details] [review]:

Yay.
Comment 5 Claudio Saavedra 2013-02-07 22:06:42 UTC
Attachment 235348 [details] pushed as 65f5514 - ephy-session.c: add ephy_session_clear()
Attachment 235349 [details] pushed as 0129db9 - ephy-session-test: add test for ephy_session_clear()