After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 69329 - pango-ot, arabic-xft, markings shaping handling
pango-ot, arabic-xft, markings shaping handling
Status: RESOLVED DUPLICATE of bug 117282
Product: pango
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: 1.4.0
Assigned To: pango-maint
pango-maint
: 98875 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2002-01-22 00:06 UTC by Elliot Lee
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
The patch (9.11 KB, patch)
2002-01-22 00:16 UTC, Elliot Lee
none Details | Review

Description Elliot Lee 2002-01-22 00:06:04 UTC
Before this patch gets totally lost...

Original message said:

I changed pango_ot_ruleset_shape to use the GPOS info if available, but
there's none to use, and I don't know how to synthesize it (is there a way
to stick that sort of stuff into the ruleset?)

I've got a patch that basically has pango_ot_ruleset_shape doing basic
shaping, and then arabic-xft fixing up the positioning on the non-spacing
marks. The problem I've run into is that in order to figure out whether a
fixup is needed on a particular glyph (via g_unichar_type())  one needs to
do glyph <-> unichar mapping, which I don't know how to do 100% of the
time, since I think there are cases where num_glyphs != num_chars.

There is also the issue of whether handling these non-spacing marks could
be done generically - I don't know enough about how most languages use
these marks to say whether that is possible.

Patch thus far attached, comments requested.
Comment 1 Elliot Lee 2002-01-22 00:16:57 UTC
Created attachment 6466 [details] [review]
The patch
Comment 2 Owen Taylor 2002-02-13 22:51:00 UTC
Eric Mader is working on Indic OpenType shaper modules that
use GPOS. I want to wait until we work on integrating that before
dealing with this patch.
Comment 3 Owen Taylor 2002-11-18 15:33:42 UTC
*** Bug 98875 has been marked as a duplicate of this bug. ***
Comment 4 Owen Taylor 2003-11-17 21:37:29 UTC
The opentype/ part of this was applied some time ago with
the indic code. The rest is subsumed by the patches in 117282.

*** This bug has been marked as a duplicate of 117282 ***