After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693263 - typefinding: MPEG-2 video ES detected as H.263
typefinding: MPEG-2 video ES detected as H.263
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: 1.6.4
Assigned To: Reynaldo H. Verdejo Pinochet
GStreamer Maintainers
1.6.4
Depends on:
Blocks:
 
 
Reported: 2013-02-06 15:22 UTC by Baby octopus
Modified: 2016-04-15 16:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
WIP solution (do not push) (2.33 KB, patch)
2014-02-21 23:33 UTC, Reynaldo H. Verdejo Pinochet
none Details | Review
strengthen check for valid H.263 picture layer (2.29 KB, patch)
2016-01-23 02:52 UTC, Reynaldo H. Verdejo Pinochet
committed Details | Review

Description Baby octopus 2013-02-06 15:22:07 UTC
When I try to decode an mpeg interlaced elementary stream with the following pipeline 

gst-launch-1.0 -v filesrc location=/mnt/hgfs/d/test/libav/carrace.m2v ! decodebin ! filesink location=/mnt/hgfs/d/test/libav/carrace.yuv 

I get following error /GstPipeline:pipeline0/GstDecodeBin:decodebin0/GstTypeFindElement:typefind.GstPad:src: caps = video/x-h263 
Missing element: H.263 decoder

Not sure why typefind is finding this as an H263 stream 

Interestingly, the following pipeline works perfectly 

gst-launch-1.0 -v filesrc location=/mnt/hgfs/d/test/libav/carrace.m2v ! mpegvideoparse ! avdec_mpeg2video ! filesink location=/mnt/hgfs/d/test/libav/carrace.yuv 

SO in short, mpeg2 elementary streams are detected as H263 streams
Comment 1 Baby octopus 2013-02-06 15:26:32 UTC
Mpeg2 elementary stream is uploaded at http://www.2shared.com/file/eSJehOtb/carrace.html
Comment 2 Tim-Philipp Müller 2013-02-06 15:56:41 UTC
Could you make the file available  some other way? The site just returns a iLividSetup.exe binary instead of the file on downlod.
Comment 3 Baby octopus 2013-02-06 18:13:20 UTC
Also shared at http://ge.tt/3e5ZneX/v/0
Comment 4 RajuB 2013-06-13 07:51:37 UTC
Hi,

Any progress on this thread??

Regards
JasonP
Comment 5 Reynaldo H. Verdejo Pinochet 2014-02-21 23:33:11 UTC
Created attachment 269961 [details] [review]
WIP solution (do not push)

This is a quickly drafted solution. Works form me with
the H.264 samples I have without matching for MPEG ES.
The problem in general is the few trivial tests that
can be performed on the H.263 header and their lax
nature. I plan to work on this one a bit more so I'm
providing it here just for testing purposes.
Comment 6 Reynaldo H. Verdejo Pinochet 2014-02-21 23:35:41 UTC
(In reply to comment #5)
> Created an attachment (id=269961) [details] [review]
> WIP solution (do not push)
> 
> This is a quickly drafted solution. Works form me with
> the H.264 samples I have without matching for MPEG ES.

s/H.264/H.263/g
Comment 7 Reynaldo H. Verdejo Pinochet 2014-02-22 16:07:27 UTC
I definitely need to work more on this one. The patch
is an ugly hack that just happens to work for my
limited set of samples. Will post a new one once I
manage to figure out a clean way of making the finder
more reliable.
Comment 8 Sebastian Dröge (slomo) 2014-05-26 12:55:58 UTC
Reynaldo?
Comment 9 Reynaldo H. Verdejo Pinochet 2015-11-30 22:09:52 UTC
Pong. Got sidetracked. Will take a another look at this now.
Comment 10 Reynaldo H. Verdejo Pinochet 2016-01-23 02:52:20 UTC
Created attachment 319579 [details] [review]
strengthen check for valid H.263 picture layer

This one gets rid of this false positive for H.263 and possibly others, without
borking proper identification of valid H.263 streams. The changed var name
makes the code easier to understand when reading alongside the spec
Comment 11 Reynaldo H. Verdejo Pinochet 2016-02-17 19:47:22 UTC
Review of attachment 319579 [details] [review]:

Calling it done here then. Pushed
Comment 12 Tim-Philipp Müller 2016-03-03 16:25:20 UTC
Picked into 1.6.4.
Comment 13 Reynaldo H. Verdejo Pinochet 2016-04-15 16:18:41 UTC
(In reply to Tim-Philipp Müller from comment #12)
> Picked into 1.6.4.

Good stuff. Thank you.