After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693256 - wayland: use the GdkCursorType enum information to lookup the cursor name
wayland: use the GdkCursorType enum information to lookup the cursor name
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-02-06 11:14 UTC by Thomas Wood
Modified: 2013-02-06 17:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wayland: use the GdkCursorType enum information to lookup the cursor name (2.66 KB, patch)
2013-02-06 11:14 UTC, Thomas Wood 		committed Details | Review

Description Thomas Wood 2013-02-06 11:14:02 UTC 
Use the enum information to generate the cursor name rather than using a
lookup table.
Comment 1 Thomas Wood 2013-02-06 11:14:04 UTC 
Created attachment 235302 [details] [review]
wayland: use the GdkCursorType enum information to lookup the cursor name

Use the enum information to generate the cursor name rather than using a
lookup table.
Comment 2 Rob Bradford 2013-02-06 14:15:24 UTC 
Review of attachment 235302 [details] [review]:

(optionally) apply recommendations and commit.

::: gdk/wayland/gdkcursor-wayland.c
@@ +261,1 @@
+  enum_class = g_type_class_ref (GDK_TYPE_CURSOR_TYPE);

replace with g_type_class_peek ?

@@ +263,3 @@
+  cursor_name = g_strdup (enum_value->value_nick);
+  g_strdelimit (cursor_name, "-", '_');
+  g_type_class_unref (enum_class);

and so can drop this
Comment 3 Thomas Wood 2013-02-06 17:00:43 UTC 
Attachment 235302 [details] pushed as 4f6d535 - wayland: use the GdkCursorType enum information to lookup the cursor name