GNOME Bugzilla – Bug 693240
places: Rename 'File System' to 'Computer' and capitalize 'Network'
Last modified: 2013-02-13 21:47:11 UTC
Use title case for 'Browse Network' and use the same name for 'Computer' as Nautilus. I also think we should consider changing 'Browse Network' to just 'Network' though. We don't say 'Browse Computer' or 'Browse Pictures'.
Created attachment 235286 [details] [review] places: Rename 'File System' to 'Computer' and capitalize 'Network' The Nautilus sidebar calls it 'Computer' so we should too. Use title case for "Browse Network"
Review of attachment 235286 [details] [review]: OK.
Attachment 235286 [details] pushed as 61ee59f - places: Rename 'File System' to 'Computer' and capitalize 'Network'
Uh, Adel, you aren't a maintainer of Classic Mode.
(In reply to comment #4) > Uh, Adel, you aren't a maintainer of Classic Mode. Heh, I don't think we need this much formality. As long as we're not breaking anything...
It is not called 'Computer' but 'kolache' (my hostname) on my system with Nautilus 3.7.5.
Indeed. Nautilus uses your hostname, as pulled from /org/freedesktop/hostname1
It's just 'Computer' on Ubuntu which apparently is the fallback :(
Created attachment 235624 [details] [review] places-menu: show the computer pretty name for the file system root As Nautilus does, query hostnamed for the pretty hostname and watch for changes. If hostnamed is not available, we just show Computer, as before.
(In reply to comment #4) > Uh, Adel, you aren't a maintainer of Classic Mode. Indeed am I not ... just was going over the review queue and this was a rather simply patch that looked technically OK to me. Anyway will let Florian review the new patch then.
(In reply to comment #10) > Anyway will let Florian review the new patch then. I'm not quite sure when being a maintainer became a requirement for patch reviews (I don't think you are listed as shell maintainer either, but your reviews are certainly appreciated), or what "maintainer of classic mode" even means - it is part of the gnome-shell-extensions module, of which I'm not a maintainer either. For what it's worth, Giovanni (who *does* maintain the module) appeared to be fine with you reviewing the patch ...
Review of attachment 235624 [details] [review]: Looks good.
Attachment 235624 [details] pushed as 2f5c095 - places-menu: show the computer pretty name for the file system root