After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693213 - class-gen: Fixes for the class-gen plugin
class-gen: Fixes for the class-gen plugin
Status: RESOLVED FIXED
Product: anjuta
Classification: Applications
Component: Plugins: class-gen
unspecified
Other All
: Normal normal
: ---
Assigned To: Armin Burgmeier
Anjuta maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-05 17:04 UTC by Carl-Anton Ingmarsson
Modified: 2013-02-06 21:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
class-gen: fix compile warnings (5.92 KB, patch)
2013-02-05 17:04 UTC, Carl-Anton Ingmarsson
committed Details | Review
project-wizard: move license templates to data/ (5.83 KB, patch)
2013-02-05 17:04 UTC, Carl-Anton Ingmarsson
committed Details | Review
class-gen: generate license the same way as project-wizard (8.61 KB, patch)
2013-02-05 17:04 UTC, Carl-Anton Ingmarsson
committed Details | Review
class-gen: output filename instead of project name before copyright (4.90 KB, patch)
2013-02-05 17:04 UTC, Carl-Anton Ingmarsson
committed Details | Review
class-gen: Always generate GObject private structure (3.43 KB, patch)
2013-02-05 17:04 UTC, Carl-Anton Ingmarsson
committed Details | Review

Description Carl-Anton Ingmarsson 2013-02-05 17:04:25 UTC
See the attached patches.
Comment 1 Carl-Anton Ingmarsson 2013-02-05 17:04:28 UTC
Created attachment 235231 [details] [review]
class-gen: fix compile warnings
Comment 2 Carl-Anton Ingmarsson 2013-02-05 17:04:31 UTC
Created attachment 235232 [details] [review]
project-wizard: move license templates to data/

since the class-gen plugin also uses them it makes sense to have them
outside the project-wizard plugin
Comment 3 Carl-Anton Ingmarsson 2013-02-05 17:04:33 UTC
Created attachment 235233 [details] [review]
class-gen: generate license the same way as project-wizard

this fixes a problem where the prefix character was missing for the
first line in the generated header
Comment 4 Carl-Anton Ingmarsson 2013-02-05 17:04:36 UTC
Created attachment 235234 [details] [review]
class-gen: output filename instead of project name before copyright
Comment 5 Carl-Anton Ingmarsson 2013-02-05 17:04:39 UTC
Created attachment 235235 [details] [review]
class-gen: Always generate GObject private structure

Having a private structure generated is often what you want even though you
haven't defined any private members in the dialog.

Also don't generate the _GET_PRIVATE() macro anymore but instead just
initialize the ->priv pointer in instance init.

Also remove unused parent_class variable in the generated
class_init function.
Comment 6 Sébastien Granjoux 2013-02-06 21:12:23 UTC
Thanks, I have committed all this patches with any changes, except whitespaces.