After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693210 - gnome-session-selector: don't install man page and .ui file of not building
gnome-session-selector: don't install man page and .ui file of not building
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: gnome-session
unspecified
Other Windows
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-05 16:14 UTC by Dominique Leuenberger
Modified: 2013-02-07 06:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't install man page and .ui file if not installing the session selector. (1.35 KB, patch)
2013-02-05 16:15 UTC, Dominique Leuenberger 		committed Details | Review
gnome-session-selector: 'Port' to Gtk3. (838 bytes, patch)
2013-02-06 18:46 UTC, Dominique Leuenberger 		committed Details | Review

Description Dominique Leuenberger 2013-02-05 16:14:20 UTC 
http://git.gnome.org/browse/gnome-session/commit/?id=6186a4a6f1fc1a34e188db4fe6d6e8035afea36d

introduces a new gnome-session-selector.

But even if it is not being built (not passing --enable-session-selector to configure, thus disabled), the man page for it and the .ui file are being installed.
Comment 1 Dominique Leuenberger 2013-02-05 16:15:00 UTC 
Created attachment 235226 [details] [review]
Don't install man page and .ui file if not installing the session selector.
Comment 2 Dominique Leuenberger 2013-02-05 16:15:28 UTC 
And BTW: GTK2? Really ? :)
Comment 3 Matthias Clasen 2013-02-06 02:34:27 UTC 
Well, somebody should port it...can't be much more than s/2/3/ in a pkg-config check.
Comment 4 Dominique Leuenberger 2013-02-06 18:46:48 UTC 
Created attachment 235324 [details] [review]
gnome-session-selector: 'Port' to Gtk3.
Comment 5 Dominique Leuenberger 2013-02-06 18:47:57 UTC 
(In reply to comment #3)
> Well, somebody should port it...

Done..

The two patches here should both be considered to be applied.
Comment 6 Matthias Clasen 2013-02-07 02:11:49 UTC 
Review of attachment 235226 [details] [review]:

Looks good
Comment 7 Matthias Clasen 2013-02-07 02:12:32 UTC 
Review of attachment 235324 [details] [review]:

ok
Comment 8 Matthias Clasen 2013-02-07 02:12:43 UTC 
Review of attachment 235324 [details] [review]:

ok
Comment 9 Dominique Leuenberger 2013-02-07 06:57:39 UTC 
Patches pushed...

all done.