After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693146 - tsdemux: doesn't expose VC1 pad when descriptor is missing
tsdemux: doesn't expose VC1 pad when descriptor is missing
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.x
Other Linux
: Normal normal
: 1.0.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-02-04 15:52 UTC by Josep Torra Valles
Modified: 2013-02-06 11:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch that fixes the issue (1.95 KB, patch)
2013-02-04 15:52 UTC, Josep Torra Valles 		committed Details | Review

Description Josep Torra Valles 2013-02-04 15:52:48 UTC 
Created attachment 235154 [details] [review]
Patch that fixes the issue

I've some media that can be played with flutsdemux in 0.10 but not with tsdemux 1.0.

Actually there's code in tsdemux to expose VC1 pad after checking on a certain descriptor.

There's also a GST_WARNING line that doesn't seems to be executed in the right condition.

The provided patch fixes the issues I've observed with my media files.
Comment 1 Tim-Philipp Müller 2013-02-05 19:52:48 UTC 
Comment on attachment 235154 [details] [review]
Patch that fixes the issue

Looks ok to push to master IMHO.

I am not sure if we should be exposing the pad as VC-1 if there is a format_identifier and it's != DRF_ID_VC1, but arguably that point applies to some of the other formats as well, and hopefully it's only a theoretical case.
Comment 2 Josep Torra Valles 2013-02-05 22:15:55 UTC 
Commit: 7fafbe2e22a83b68450174f7919f02650d52b805
Author: Josep Torra <n770galaxy@gmail.com>
Date:   Tue Feb  5 23:07:12 2013 +0100

tsdemux: expose VC1 streams with missing descriptor.

Fixes playback of VC1 streams when the descriptor is missing.