GNOME Bugzilla – Bug 693110
Add bold/half/standout/blink information to libvte's char attributes.
Last modified: 2021-06-10 14:40:51 UTC
Created attachment 235126 [details] [review] Patch to copy four more attributes from cell to charattributes structure. Hi, I'm using the libvte library as the server side backend of my web-based terminal (http://github.com/berenm/anyterm), and I've been stuck with bold/faint/bright/blink character detection. I find it very hard to determine that from the palette colors, given the said colors can also be used without bold or bright... flags. I wrote a small patch, attached, that adds the missing attributes to the vte charattribute structure, and I would definitely appreciate if it could be included in vte for future releases. If there's any reason this is not possible (and maybe the reasons why it wasn't done already), please let me know. Best, -- Beren Minor
Please also see bug 616436 which kinda goes in the opposite direction. Remembering and exposing attributes such as "bold" and "blink" does make sense; however, attributes that influence the color ("bright", "half", "standout") probably don't on their own. I think it's only the actual final color that should be remembered. Or, if we want to be able to recover for each cell which escape codes were used to achieve the cell's attributes, we'd for example have to have internal support for 272+ colors (8 for SGR 30..37, 8 for SGR 90..97, and 256 for SGR 38;5;0..255, and also the default fg/bg colors and friends). This is because they behave in weird and different ways as they change with the bold/half/standout attributes... Sounds too complicated to me (but I'm not a vte developer, just a random dude commenting here).
My previous comment is now obsolete.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/vte/-/issues/1992.