After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 693074 - apps-menu: keynav
apps-menu: keynav
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
classic
Depends on:
Blocks:
 
 
Reported: 2013-02-02 23:57 UTC by Matthias Clasen
Modified: 2013-04-07 19:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
apps-menu: Allow for keynav between categories/applications (1.83 KB, patch)
2013-04-05 16:14 UTC, Florian Müllner 		none Details | Review
apps-menu: Allow for keynav between categories/applications (1.67 KB, patch)
2013-04-05 16:56 UTC, Florian Müllner 		committed Details | Review

Description Matthias Clasen 2013-02-02 23:57:35 UTC 
Moving the selected category with up/down works nicely.
But if I hit right to go into the submenu, I get the calendar instead.
Comment 1 Florian Müllner 2013-04-05 16:14:40 UTC 
Created attachment 240769 [details] [review]
apps-menu: Allow for keynav between categories/applications

PanelMenu.Button listens to key-press-events on the corresponding
menu to move focus to neighboring buttons on left/right arrow. In
order to allow keynav from the category list on the left to the
application list on the right and vice-versa, we may need to suppress
the parent behavior depending on the currently focused actor, so
overwrite the signal handler accordingly.
Comment 2 Florian Müllner 2013-04-05 16:56:25 UTC 
Created attachment 240771 [details] [review]
apps-menu: Allow for keynav between categories/applications

Simplified version.
Comment 3 Rui Matos 2013-04-07 18:53:24 UTC 
Review of attachment 240771 [details] [review]:

Looks fine otherwise.

::: extensions/apps-menu/extension.js
@@ +319,3 @@
+                                                       : Gtk.DirectionType.RIGHT;
+            if (this.menu.actor.navigate_focus(global.stage.key_focus, direction, false))
+                return false;

Should return true.
Comment 4 Florian Müllner 2013-04-07 19:12:28 UTC 
Attachment 240771 [details] pushed as 9494184 - apps-menu: Allow for keynav between categories/applications